From 982bcff357d0cb255f9c2e0fed3b4a73fcb37636 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Sat, 14 Mar 2020 18:18:45 -0400 Subject: [PATCH] Don't log "Unknown browser" for requests from Safari App Extension --- chrome/content/zotero/xpcom/connector/server_connector.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/chrome/content/zotero/xpcom/connector/server_connector.js b/chrome/content/zotero/xpcom/connector/server_connector.js index 49a534a05b..52b6f26c92 100644 --- a/chrome/content/zotero/xpcom/connector/server_connector.js +++ b/chrome/content/zotero/xpcom/connector/server_connector.js @@ -1450,6 +1450,7 @@ Zotero.Server.Connector.Ping.prototype = { var browser; var message; var showDownloadButton = false; + // Legacy Safari extension if (origin && origin.startsWith('safari-extension')) { browser = 'safari'; message = `An update is available for the ${appName} Connector for Safari.\n\n` @@ -1467,6 +1468,10 @@ Zotero.Server.Connector.Ping.prototype = { + `You can upgrade to the latest version from ${domain}.`; showDownloadButton = true; } + // Safari App Extension is always up to date + else if (req.headers['User-Agent'] && req.headers['User-Agent'].includes('Safari/')) { + return; + } else { Zotero.debug("Unknown browser"); return;