From 978e2c32b4c29d8aaf8579c97185c0558eaed56f Mon Sep 17 00:00:00 2001
From: Dan Stillman <dstillman@zotero.org>
Date: Tue, 21 Dec 2021 02:17:35 -0500
Subject: [PATCH] Remove "Toggle Tag Selector" command from Shortcuts
 preference pane

Cmd/Ctrl-Shift-T is now used for reopening a closed tab

This is now a View menu option, so macOS users can assign an
app-specific shortcut key for it. For other platforms that can't do
that, Zutilo could add it, and it will be an option if we add general
key-binding configurability in a future version.

Closes #2281
---
 chrome/content/zotero/preferences/preferences_advanced.xul | 7 -------
 chrome/content/zotero/zoteroPane.js                        | 3 ---
 chrome/locale/en-US/zotero/preferences.dtd                 | 1 -
 defaults/preferences/zotero.js                             | 1 -
 4 files changed, 12 deletions(-)

diff --git a/chrome/content/zotero/preferences/preferences_advanced.xul b/chrome/content/zotero/preferences/preferences_advanced.xul
index 9a9a12c868..518198f8a5 100644
--- a/chrome/content/zotero/preferences/preferences_advanced.xul
+++ b/chrome/content/zotero/preferences/preferences_advanced.xul
@@ -51,7 +51,6 @@
 			<preference id="pref-keys-saveToZotero" name="extensions.zotero.keys.saveToZotero" type="string"/>
 			<preference id="pref-keys-library" name="extensions.zotero.keys.library" type="string"/>
 			<preference id="pref-keys-quicksearch" name="extensions.zotero.keys.quicksearch" type="string"/>
-			<preference id="pref-keys-toggleTagSelector" name="extensions.zotero.keys.toggleTagSelector" type="string"/>
 			<preference id="pref-keys-newItem" name="extensions.zotero.keys.newItem" type="string"/>
 			<preference id="pref-keys-newNote" name="extensions.zotero.keys.newNote" type="string"/>
 			<preference id="pref-keys-toggleRead" name="extensions.zotero.keys.toggleRead" type="string"/>
@@ -270,12 +269,6 @@
 										onchange="if (Zotero_Preferences.Export) { Zotero_Preferences.Export.updateQuickCopyInstructions(); }"/>
 							</row>
 							
-							<row>
-								<label value="&zotero.preferences.keys.toggleTagSelector;" control="textbox-toggleTagSelector"/>
-								<label class="modifier"/>
-								<textbox id="textbox-toggleTagSelector" maxlength="1" size="1" preference="pref-keys-toggleTagSelector"/>
-							</row>
-
 							<row>
 								<label value="&zotero.preferences.keys.toggleAllRead;" control="textbox-toggleAllRead"/>
 								<label class="modifier"/>
diff --git a/chrome/content/zotero/zoteroPane.js b/chrome/content/zotero/zoteroPane.js
index 261dfa4082..1e8241cfc4 100644
--- a/chrome/content/zotero/zoteroPane.js
+++ b/chrome/content/zotero/zoteroPane.js
@@ -809,9 +809,6 @@ var ZoteroPane = new function()
 					// Use key that's not the modifier as the popup toggle
 					ZoteroPane_Local.newNote(event.altKey, parentKey);
 					break;
-				case 'toggleTagSelector':
-					ZoteroPane_Local.toggleTagSelector();
-					break;
 				case 'sync':
 					Zotero.Sync.Runner.sync();
 					break;
diff --git a/chrome/locale/en-US/zotero/preferences.dtd b/chrome/locale/en-US/zotero/preferences.dtd
index 96812d7fe0..b761b97e59 100644
--- a/chrome/locale/en-US/zotero/preferences.dtd
+++ b/chrome/locale/en-US/zotero/preferences.dtd
@@ -134,7 +134,6 @@
 <!ENTITY zotero.preferences.keys.newItem					"Create a New Item">
 <!ENTITY zotero.preferences.keys.newNote					"Create a New Note">
 <!ENTITY zotero.preferences.keys.toggleAllRead				"Mark All Feed Items As Read/Unread">
-<!ENTITY zotero.preferences.keys.toggleTagSelector		"Toggle Tag Selector">
 <!ENTITY zotero.preferences.keys.copySelectedItemCitationsToClipboard		"Copy Selected Item Citations to Clipboard">
 <!ENTITY zotero.preferences.keys.copySelectedItemsToClipboard		"Copy Selected Items to Clipboard">
 <!ENTITY zotero.preferences.keys.importFromClipboard		"Import from Clipboard">
diff --git a/defaults/preferences/zotero.js b/defaults/preferences/zotero.js
index c8de014c49..65c4ed4e9c 100644
--- a/defaults/preferences/zotero.js
+++ b/defaults/preferences/zotero.js
@@ -85,7 +85,6 @@ pref("extensions.zotero.keys.library", "L");
 pref("extensions.zotero.keys.quicksearch", "K");
 pref("extensions.zotero.keys.copySelectedItemCitationsToClipboard", "A");
 pref("extensions.zotero.keys.copySelectedItemsToClipboard", "C");
-pref("extensions.zotero.keys.toggleTagSelector", "T");
 pref("extensions.zotero.keys.sync", "Y");
 pref("extensions.zotero.keys.toggleAllRead", "R");
 pref("extensions.zotero.keys.toggleRead", "`");