mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Don't mark an empty field set to an empty string as changed

Browse source 
And some tests
This commit is contained in:
Dan Stillman 2015-05-05 04:45:48 -04:00
parent 0cefa03827
commit 93a6a4ffdb
2 changed files with 47 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

43
test/tests/itemTest.js
View file

@ -19,6 +19,49 @@ describe("Zotero.Item", function () {
});
describe("#setField", function () {
it("should mark a field as changed", function () {
var item = new Zotero.Item('book');
item.setField('title', 'Foo');
assert.ok(item._changed.itemData[Zotero.ItemFields.getID('title')]);
assert.ok(item.hasChanged());
})
it("should clear an existing field set to a falsy value", function () {
var field = 'title';
var fieldID = Zotero.ItemFields.getID(field);
var item = new Zotero.Item('book');
item.setField(field, 'Foo');
id = yield item.save();
item = yield Zotero.Items.getAsync(id);
item.setField(field, "");
assert.ok(item._changed.itemData[fieldID]);
assert.ok(item.hasChanged());
yield item.reload();
assert.isFalse(item.hasChanged());
item.setField(field, false);
assert.ok(item._changed.itemData[fieldID]);
assert.ok(item.hasChanged());
yield item.reload();
assert.isFalse(item.hasChanged());
item.setField(field, null);
assert.ok(item._changed.itemData[fieldID]);
assert.ok(item.hasChanged());
yield item.save();
assert.isFalse(item.getField(fieldID));
})
it("should not mark an empty field set to an empty string as changed", function () {
var item = new Zotero.Item('book');
item.setField('url', '');
assert.isUndefined(item._changed.itemData);
})
it("should save version as object version", function* () {
var item = new Zotero.Item('book');
item.setField("version", 1);