From 909d68eac30b5acf9bf7024c7f30b4a702ebef6a Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Wed, 11 May 2022 06:10:14 -0400 Subject: [PATCH] fx-compat: Fix New Item menu --- chrome/content/zotero/zoteroPane.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/chrome/content/zotero/zoteroPane.js b/chrome/content/zotero/zoteroPane.js index 9bf471501c..cf980a1b87 100644 --- a/chrome/content/zotero/zoteroPane.js +++ b/chrome/content/zotero/zoteroPane.js @@ -281,10 +281,9 @@ var ZoteroPane = new function() var addMenu = document.getElementById('zotero-tb-add').firstElementChild; // Remove all nodes so we can regenerate - var options = addMenu.querySelectorAll('.zotero-tb-add'); + var options = [...addMenu.querySelectorAll('.zotero-tb-add')]; while (options.length) { - var p = options[0].parentNode; - p.removeChild(options[0]); + options.shift().remove(); } var moreMenu = document.getElementById('zotero-tb-add-more'); while (moreMenu.hasChildNodes()) { @@ -308,7 +307,7 @@ var ZoteroPane = new function() return collation.compareString(1, a.localized, b.localized); }); for (let itemType of itemTypes) { - let menuitem = document.createElement("menuitem"); + let menuitem = document.createXULElement("menuitem"); menuitem.setAttribute("label", itemType.localized); menuitem.setAttribute("tooltiptext", ""); let type = itemType.id; @@ -333,7 +332,7 @@ var ZoteroPane = new function() return collation.compareString(1, a.localized, b.localized); }); for (var i = 0; i