mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fix data mismatch false positives

Browse source
This commit is contained in:
Simon Kornblith 2012-07-12 10:01:59 -04:00
parent b5e4334df5
commit 8c4e2f0d49
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
chrome/content/zotero/tools/testTranslators/translatorTester.js
View file

@ -507,7 +507,7 @@ Zotero_TranslatorTester.prototype._checkResult = function(test, translate, retur
if(!this._compare(testItem, translatedItem)) { if(!this._compare(testItem, translatedItem)) {
// Show diff // Show diff
this._debug(this, "Data mismatch detected:"); this._debug(this, "TranslatorTester: Data mismatch detected:");
this._debug(this, this._generateDiff(testItem, translatedItem)); this._debug(this, this._generateDiff(testItem, translatedItem));
// Save items. This makes it easier to correct tests automatically. // Save items. This makes it easier to correct tests automatically.
@ -602,7 +602,7 @@ Zotero_TranslatorTester.prototype._compare = function(a, b) {
} }
for(var key in a) { for(var key in a) {
if(!a.hasOwnProperty(key)) continue; if(!a.hasOwnProperty(key)) continue;
if(!b.hasOwnProperty(key)) return false; if(a[key] !== false && !b.hasOwnProperty(key)) return false;
if(!this._compare(a[key], b[key])) return false; if(!this._compare(a[key], b[key])) return false;
} }
for(var key in b) { for(var key in b) {