From 8c37865c07653c3f095d83175cbd8314ca7c33c3 Mon Sep 17 00:00:00 2001 From: Abe Jellinek Date: Mon, 8 May 2023 20:13:47 +0300 Subject: [PATCH] Fix add-on install error message when file is entirely invalid If the file wasn't an XPI at all, or it didn't contain valid metadata for fx102, the error message would previously show "%S" where the add-on name should be. Now we fall back to the file path. --- chrome/content/zotero/standalone/standalone.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chrome/content/zotero/standalone/standalone.js b/chrome/content/zotero/standalone/standalone.js index 6c1515a22a..bc188b65e4 100644 --- a/chrome/content/zotero/standalone/standalone.js +++ b/chrome/content/zotero/standalone/standalone.js @@ -959,7 +959,7 @@ const gXPInstallObserver = { Zotero.alert( null, Zotero.getString("standalone.addonInstallationFailed.title"), - Zotero.getString("standalone.addonInstallationFailed.body", installs[0].name)); + Zotero.getString("standalone.addonInstallationFailed.body", [installs[0].name || installs[0].file.path])); break; /*case "addon-install-started": case "addon-install-complete":*/