diff --git a/chrome/content/zotero/preferences/preferences_general.js b/chrome/content/zotero/preferences/preferences_general.js index cee4c83369..c2272c1b9b 100644 --- a/chrome/content/zotero/preferences/preferences_general.js +++ b/chrome/content/zotero/preferences/preferences_general.js @@ -41,6 +41,10 @@ Zotero_Preferences.General = { var menuitem = document.getElementById('fileHandler-internal'); menuitem.setAttribute('label', Zotero.appName); + if (Zotero.isPDFBuild) { + document.getElementById('useInternalPDFReader-checkbox').hidden = false; + } + this.updateAutoRenameFilesUI(); this._updateFileHandlerUI(); }, diff --git a/chrome/content/zotero/preferences/preferences_general.xul b/chrome/content/zotero/preferences/preferences_general.xul index 65225fca8d..744d8b558b 100644 --- a/chrome/content/zotero/preferences/preferences_general.xul +++ b/chrome/content/zotero/preferences/preferences_general.xul @@ -80,8 +80,10 @@ + preference="pref-useInternalPDFReader" + hidden="true"/> diff --git a/chrome/content/zotero/xpcom/openPDF.js b/chrome/content/zotero/xpcom/openPDF.js index bbc7c7ab13..67f394e6a5 100644 --- a/chrome/content/zotero/xpcom/openPDF.js +++ b/chrome/content/zotero/xpcom/openPDF.js @@ -36,7 +36,9 @@ Zotero.OpenPDF = { else { let item = pathOrItem; let library = Zotero.Libraries.get(item.libraryID); - if (library.libraryType == 'user' && Zotero.Prefs.get('beta.useInternalPDFReader')) { + if (Zotero.isPDFBuild + && library.libraryType == 'user' + && Zotero.Prefs.get('beta.useInternalPDFReader')) { let location = { pageIndex: page - 1 }; diff --git a/chrome/content/zotero/xpcom/zotero.js b/chrome/content/zotero/xpcom/zotero.js index 9c3d2d4533..55411a2bce 100644 --- a/chrome/content/zotero/xpcom/zotero.js +++ b/chrome/content/zotero/xpcom/zotero.js @@ -228,7 +228,11 @@ Services.scriptloader.loadSubScript("resource://zotero/polyfill.js"); var version = yield deferred.promise; } Zotero.version = version; - Zotero.isDevBuild = Zotero.version.includes('beta') || Zotero.version.includes('SOURCE'); + Zotero.isDevBuild = Zotero.version.includes('beta') + || Zotero.version.includes('dev') + || Zotero.version.includes('SOURCE'); + Zotero.isPDFBuild = true // Toggle for testing + && (Zotero.version.includes('dev') || Zotero.version.includes('SOURCE')); // OS platform var win = Components.classes["@mozilla.org/appshell/appShellService;1"] diff --git a/chrome/content/zotero/zoteroPane.js b/chrome/content/zotero/zoteroPane.js index 36f9c95d68..ce6ce5784b 100644 --- a/chrome/content/zotero/zoteroPane.js +++ b/chrome/content/zotero/zoteroPane.js @@ -4098,7 +4098,9 @@ var ZoteroPane = new function() let item = await Zotero.Items.getAsync(itemID); let library = Zotero.Libraries.get(item.libraryID); // TEMP - if (library.libraryType == 'user' && Zotero.Prefs.get('beta.useInternalPDFReader')) { + if (Zotero.isPDFBuild + && library.libraryType == 'user' + && Zotero.Prefs.get('beta.useInternalPDFReader')) { this.viewPDF(itemID, event && event.shiftKey); return; }