Add Feed and FeedItem

Also:
* _finalizeErase in Zotero.DataObject is now inheritable
* Call _initErase before starting a DB transaction
* removes Zotero.Libraries.add and Zotero.Libraries.remove (doesn't seem like this is used any more)

test/tests/feedItemTest.js

@@ -0,0 +1,178 @@
+describe("Zotero.FeedItem", function () {
+	let feed, libraryID;
+	before(function* () {
+		feed = new Zotero.Feed({ name: 'Test ' + Zotero.randomString(), url: 'http://' + Zotero.randomString() + '.com/' });
+		yield feed.saveTx();
+		libraryID = feed.libraryID;
+	});
+	after(function() {
+		return feed.eraseTx();
+	});
+	
+	it("should be an instance of Zotero.Item", function() {
+		assert.instanceOf(new Zotero.FeedItem(), Zotero.Item);
+	});
+	describe("#libraryID", function() {
+		it("should reference a feed", function() {
+			let feedItem = new Zotero.FeedItem();
+			assert.doesNotThrow(function() {feedItem.libraryID = feed.libraryID});
+			assert.throws(function() {feedItem.libraryID = Zotero.Libraries.userLibraryID}, /^libraryID must reference a feed$/);
+		});
+	});
+	describe("#constructor()", function* () {
+		it("should accept required fields as arguments", function* () {
+			let guid = Zotero.randomString();
+			let feedItem = new Zotero.FeedItem();
+			yield assert.isRejected(feedItem.forceSaveTx());
+			
+			feedItem = new Zotero.FeedItem('book', { guid });
+			feedItem.libraryID = libraryID;
+			yield assert.isFulfilled(feedItem.forceSaveTx());
+			
+			assert.equal(feedItem.itemTypeID, Zotero.ItemTypes.getID('book'));
+			assert.equal(feedItem.guid, guid);
+			assert.equal(feedItem.libraryID, libraryID);
+		});
+	});
+	describe("#isFeedItem", function() {
+		it("should be true", function() {
+			let feedItem = new Zotero.FeedItem();
+			assert.isTrue(feedItem.isFeedItem);
+		});
+		it("should be falsy for regular item", function() {
+			let item = new Zotero.Item();
+			assert.notOk(item.isFeedItem);
+		})
+	});
+	describe("#guid", function() {
+		it("should not be settable to a non-string value", function() {
+			let feedItem = new Zotero.FeedItem();
+			assert.throws(() => feedItem.guid = 1);
+		});
+		it("should be settable to any string", function() {
+			let feedItem = new Zotero.FeedItem();
+			feedItem.guid = 'foo';
+			assert.equal(feedItem.guid, 'foo');
+		});
+		it("should not be possible to change guid after saving item", function* () {
+			let feedItem = yield createDataObject('feedItem', { libraryID });
+			assert.throws(() => feedItem.guid = 'bar');
+		});
+	});
+	describe("#isRead", function() {
+		it("should be false by default", function* () {
+			let feedItem = yield createDataObject('feedItem', { libraryID });
+			assert.isFalse(feedItem.isRead);
+		});
+		it("should be settable and persist after saving", function* () {
+			this.timeout(5000);
+			let feedItem = new Zotero.FeedItem('book', { guid: Zotero.randomString() });
+			feedItem.libraryID = feed.libraryID;
+			assert.isFalse(feedItem.isRead);
+			
+			let expectedTimestamp = Date.now();
+			feedItem.isRead = true;
+			assert.isTrue(feedItem.isRead);
+			let readTime = Zotero.Date.sqlToDate(feedItem._feedItemReadTime, true).getTime();
+			assert.closeTo(readTime, expectedTimestamp, 2000, 'sets the read timestamp to current time');
+			
+			feedItem.isRead = false;
+			assert.isFalse(feedItem.isRead);
+			assert.notOk(feedItem._feedItemReadTime);
+			
+			expectedTimestamp = Date.now();
+			feedItem.isRead = true;
+			yield Zotero.Promise.delay(2001);
+			yield feedItem.forceSaveTx();
+			
+			readTime = yield Zotero.DB.valueQueryAsync('SELECT readTime FROM feedItems WHERE itemID=?', feedItem.id);
+			readTime = Zotero.Date.sqlToDate(readTime, true).getTime();
+			assert.closeTo(readTime, expectedTimestamp, 2000, 'read timestamp is correct in the DB');
+		});
+	});
+	describe("#save()", function() {
+		it("should require edit check override", function* () {
+			let feedItem = new Zotero.FeedItem('book', { guid: Zotero.randomString() });
+			feedItem.libraryID = feed.libraryID;
+			yield assert.isRejected(feedItem.saveTx(), /^Error: Cannot edit feedItem in read-only Zotero library$/);
+		});
+		it("should require feed being set", function* () {
+			let feedItem = new Zotero.FeedItem('book', { guid: Zotero.randomString() });
+			// Defaults to user library ID
+			yield assert.isRejected(feedItem.forceSaveTx(), /^Error: Cannot add /);
+		});
+		it("should require GUID being set", function* () {
+			let feedItem = new Zotero.FeedItem('book');
+			feedItem.libraryID = feed.libraryID;
+			yield assert.isRejected(feedItem.forceSaveTx(),  /^Error: GUID must be set before saving FeedItem$/);
+		});
+		it("should require a unique GUID", function* () {
+			let guid = Zotero.randomString();
+			let feedItem1 = yield createDataObject('feedItem', { libraryID, guid });
+			
+			let feedItem2 = createUnsavedDataObject('feedItem', { libraryID, guid });
+			yield assert.isRejected(feedItem2.forceSaveTx());
+			
+			// But we should be able to save it after deleting the original feed
+			yield feedItem1.forceEraseTx();
+			yield assert.isFulfilled(feedItem2.forceSaveTx());
+		});
+		it("should require item type being set", function* () {
+			let feedItem = new Zotero.FeedItem(null, { guid: Zotero.randomString() });
+			feedItem.libraryID = feed.libraryID;
+			yield assert.isRejected(feedItem.forceSaveTx(),  /^Error: Item type must be set before saving$/);
+		});
+		it("should save feed item", function* () {
+			let guid = Zotero.randomString();
+			let feedItem = createUnsavedDataObject('feedItem', { libraryID, guid });
+			yield assert.isFulfilled(feedItem.forceSaveTx());
+			
+			feedItem = yield Zotero.FeedItems.getAsync(feedItem.id);
+			assert.ok(feedItem);
+			assert.equal(feedItem.guid, guid);
+		});
+		it.skip("should support saving feed items with all types and fields", function* () {
+			this.timeout(60000);
+			let allTypesAndFields = loadSampleData('allTypesAndFields'),
+				feedItems = [];
+			for (let type in allTypesAndFields) {
+				let feedItem = new Zotero.FeedItem(null, type, feed.libraryID);
+				feedItem.fromJSON(allTypesAndFields[type]);
+				
+				yield feedItem.forceSaveTx();
+				
+				feedItems.push(feedItem);
+			}
+			
+			let feedItemsJSON = {};
+			for (let i=0; i<feedItems.length; i++) {
+				let feed = feedItems[i];
+				feedItemsJSON[feed.guid] = feed.toJSON();
+			}
+			
+			assert.deepEqual(feedItemsJSON, allTypesAndFields);
+		});
+		it("should allow saving after editing data", function* () {
+			let feedItem = yield createDataObject('feedItem', { libraryID });
+			
+			feedItem.setField('title', 'bar');
+			yield assert.isFulfilled(feedItem.forceSaveTx());
+			assert.equal(feedItem.getField('title'), 'bar');
+		});
+	});
+	describe("#erase()", function() {
+		it("should erase an existing feed item", function* () {
+			let feedItem = yield createDataObject('feedItem', { libraryID });
+			
+			yield feedItem.forceEraseTx();
+			assert.isFalse(yield Zotero.FeedItems.getAsync(feedItem.id));
+			
+			//yield assert.isRejected(feedItem.forceEraseTx(), "does not allow erasing twice");
+		});
+		it("should require edit check override to erase", function* () {
+			let feedItem = yield createDataObject('feedItem', { libraryID });
+			
+			yield assert.isRejected(feedItem.eraseTx(), /^Error: Cannot edit feedItem in read-only Zotero library$/);
+		});
+	});
+});