mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix items table potentially not rendering after merge

Browse source 
In d4f8c7c an entry has been removed from zotero.properties that is still being
used in items table. If `numNotes` column is visible, items table would not
render.

Instead of re-adding to zotero.properties, I've migrated this string to
zotero.ftl to fix this problem.
This commit is contained in:
Tom Najdek 2023-11-29 12:06:53 +01:00 committed by Dan Stillman
parent cec0592e14
commit 8627e92cb4
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
chrome/content/zotero/itemTree.jsx
View file

@ -2814,7 +2814,8 @@ var ItemTree = class ItemTree extends LibraryTree {
else { else {
cell = renderCell.apply(this, arguments); cell = renderCell.apply(this, arguments);
if (column.dataKey === 'numNotes' && data) { if (column.dataKey === 'numNotes' && data) {
cell.setAttribute('aria-label', Zotero.getString('pane.item.notes.count', data, data) + '.'); cell.dataset.l10nId = 'items-table-cell-notes';
cell.dataset.l10nArgs = JSON.stringify({ count: data });
} }
else if (column.dataKey === 'itemType') { else if (column.dataKey === 'itemType') {
cell.setAttribute('aria-hidden', true); cell.setAttribute('aria-hidden', true);

6
chrome/locale/en-US/zotero/zotero.ftl
View file

@ -87,6 +87,12 @@ import-online-relink-only =
.label = Relink Mendeley Desktop citations .label = Relink Mendeley Desktop citations
import-online-relink-kb = More Information import-online-relink-kb = More Information
items-table-cell-notes =
.aria-label = { $count ->
[one] { $count } Note
*[other] { $count } Notes
}
report-error = report-error =
.label = Report Error… .label = Report Error…