mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix extremely slow note editor image ArrayBuffer to data URL conversion

Browse source
This commit is contained in:
Martynas Bagdonas 2023-07-05 19:39:52 +03:00
parent 2db13c2494
commit 8017b2ab1b
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
chrome/content/zotero/xpcom/editorInstance.js
View file

@ -998,16 +998,6 @@ class EditorInstance {
} }
} }
_arrayBufferToBase64(buffer) {
var binary = '';
var bytes = new Uint8Array(buffer);
var len = bytes.byteLength;
for (var i = 0; i < len; i++) {
binary += String.fromCharCode(bytes[i]);
}
return btoa(binary);
}
_dataURLtoBlob(dataurl) { _dataURLtoBlob(dataurl) {
let parts = dataurl.split(','); let parts = dataurl.split(',');
let mime = parts[0].match(/:(.*?);/)[1]; let mime = parts[0].match(/:(.*?);/)[1];
@ -1028,7 +1018,17 @@ class EditorInstance {
let path = await item.getFilePathAsync(); let path = await item.getFilePathAsync();
let buf = await OS.File.read(path, {}); let buf = await OS.File.read(path, {});
buf = new Uint8Array(buf).buffer; buf = new Uint8Array(buf).buffer;
return 'data:' + item.attachmentContentType + ';base64,' + this._arrayBufferToBase64(buf); return new Promise((resolve, reject) => {
let blob = new Blob([buf], { type: item.attachmentContentType });
let reader = new FileReader();
reader.onloadend = function () {
resolve(reader.result);
}
reader.onerror = function (e) {
reject("FileReader error: " + e);
};
reader.readAsDataURL(blob);
});
} }
// TODO: Allow only one quickFormat dialog // TODO: Allow only one quickFormat dialog