mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Use proper alerts for export errors

Browse source
This commit is contained in:
Dan Stillman 2017-05-14 05:07:00 -04:00
parent e1986b460e
commit 7e95f8fc51
1 changed files with 28 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
chrome/content/zotero/fileInterface.js
View file

@ -107,7 +107,11 @@ Zotero_File_Exporter.prototype._exportDone = function(obj, worked) {
Zotero_File_Interface.Progress.close(); Zotero_File_Interface.Progress.close();
if(!worked) { if(!worked) {
window.alert(Zotero.getString("fileInterface.exportError")); Zotero.alert(
null,
Zotero.getString('general.error'),
Zotero.getString("fileInterface.exportError")
);
} }
} }
@ -193,7 +197,9 @@ var Zotero_File_Interface = new function() {
*/ */
function _copyToClipboard(obj, worked) { function _copyToClipboard(obj, worked) {
if(!worked) { if(!worked) {
window.alert(Zotero.getString("fileInterface.exportError")); Zotero.alert(
null, Zotero.getString('general.error'), Zotero.getString("fileInterface.exportError")
);
} else { } else {
Components.classes["@mozilla.org/widget/clipboardhelper;1"] Components.classes["@mozilla.org/widget/clipboardhelper;1"]
.getService(Components.interfaces.nsIClipboardHelper) .getService(Components.interfaces.nsIClipboardHelper)
@ -252,7 +258,11 @@ var Zotero_File_Interface = new function() {
if(!str) { if(!str) {
var ps = Components.classes["@mozilla.org/embedcomp/prompt-service;1"] var ps = Components.classes["@mozilla.org/embedcomp/prompt-service;1"]
.getService(Components.interfaces.nsIPromptService); .getService(Components.interfaces.nsIPromptService);
ps.alert(null, "", Zotero.getString('fileInterface.importClipboardNoDataError')); ps.alert(
null,
Zotero.getString('general.error'),
Zotero.getString('fileInterface.importClipboardNoDataError')
);
} }
var translation = new Zotero.Translate.Import(); var translation = new Zotero.Translate.Import();
@ -357,7 +367,11 @@ var Zotero_File_Interface = new function() {
}); });
} catch(e) { } catch(e) {
Zotero.logError(e); Zotero.logError(e);
window.alert(Zotero.getString("fileInterface.importError")); Zotero.alert(
null,
Zotero.getString('general.error'),
Zotero.getString("fileInterface.importError")
);
return; return;
} }
@ -493,7 +507,11 @@ var Zotero_File_Interface = new function() {
} }
} }
if (!haveRegularItem) { if (!haveRegularItem) {
window.alert(Zotero.getString("fileInterface.noReferencesError")); Zotero.alert(
null,
Zotero.getString('general.error'),
Zotero.getString("fileInterface.noReferencesError")
);
return; return;
} }
@ -524,7 +542,11 @@ var Zotero_File_Interface = new function() {
items, format, io.mode === "citations"); items, format, io.mode === "citations");
} }
} catch(e) { } catch(e) {
window.alert(Zotero.getString("fileInterface.bibliographyGenerationError")); Zotero.alert(
null,
Zotero.getString('general.error'),
Zotero.getString("fileInterface.bibliographyGenerationError")
);
throw(e); throw(e);
} }