mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix saving to collection from fallback search translators

Browse source 
Fixes #1028
This commit is contained in:
Dan Stillman 2016-06-11 14:54:06 -04:00
parent b0ef76cf57
commit 7dda5a2f69
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
chrome/content/zotero/xpcom/translation/translate.js
View file

@ -1225,6 +1225,7 @@ Zotero.Translate.Base.prototype = {
this._libraryID = options.libraryID; this._libraryID = options.libraryID;
this._collections = options.collections; this._collections = options.collections;
this._saveAttachments = options.saveAttachments === undefined || options.saveAttachments; this._saveAttachments = options.saveAttachments === undefined || options.saveAttachments;
this._savingAttachments = []; this._savingAttachments = [];
this._savingItems = 0; this._savingItems = 0;
this._waitingForSave = false; this._waitingForSave = false;
@ -2446,7 +2447,8 @@ Zotero.Translate.Search.prototype.complete = function(returnValue, error) {
this.translator.shift(); this.translator.shift();
this.translate({ this.translate({
libraryID: this._libraryID, libraryID: this._libraryID,
saveAttachments: this._saveAttachments saveAttachments: this._saveAttachments,
collections: this._collections
}); });
return; return;
} else { } else {

7
test/tests/lookupTest.js
View file

@ -56,9 +56,16 @@ describe.skip("Add Item by Identifier", function() {
var col = yield createDataObject('collection'); var col = yield createDataObject('collection');
yield waitForItemsLoad(win); yield waitForItemsLoad(win);
// Initial translator
var ids = yield lookupIdentifier(win, "10.4103/0976-500X.85940"); var ids = yield lookupIdentifier(win, "10.4103/0976-500X.85940");
var item = Zotero.Items.get(ids[0]); var item = Zotero.Items.get(ids[0]);
assert.equal(item.getField("title"), "Zotero: A bibliographic assistant to researcher"); assert.equal(item.getField("title"), "Zotero: A bibliographic assistant to researcher");
assert.isTrue(item.inCollection(col.id)); assert.isTrue(item.inCollection(col.id));
// Fallback translator
var ids = yield lookupIdentifier(win, "10.5281/zenodo.55073");
var item = Zotero.Items.get(ids[0]);
assert.equal(item.getField("title"), "Comparison of Spectral Methods Through the Adjacency Matrix and the Laplacian of a Graph");
assert.isTrue(item.inCollection(col.id));
}); });
}); });