From 7a9bd56b9d4cb480d0a864b99b5fc7c2da45b567 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adomas=20Ven=C4=8Dkauskas?= Date: Thu, 14 Oct 2021 15:33:43 +0300 Subject: [PATCH] Fix when dragging outside of the text of item pane message. Closes #2223 --- chrome/content/zotero/itemTree.jsx | 6 +++--- chrome/skin/default/zotero/overlay.css | 9 ++------- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/chrome/content/zotero/itemTree.jsx b/chrome/content/zotero/itemTree.jsx index f7ba5ad693..b60244e5ba 100644 --- a/chrome/content/zotero/itemTree.jsx +++ b/chrome/content/zotero/itemTree.jsx @@ -1982,12 +1982,12 @@ var ItemTree = class ItemTree extends LibraryTree { Zotero.DragDrop.currentOrientation = getDragTargetOrient(event); Zotero.debug(`Dragging over item ${row} with ${Zotero.DragDrop.currentOrientation}, drop row: ${this._dropRow}`); - var target = event.target; + var target = event.currentTarget; if (target.classList.contains('items-tree-message')) { let doc = target.ownerDocument; // Consider a drop on the items pane message box (e.g., when showing the welcome text) // a drop on the items tree - if (target.firstChild.hasAttribute('allowdrop')) { + if (target.firstChild.dataset.allowdrop) { target = doc.querySelector('#zotero-items-tree treechildren'); } else { @@ -3049,7 +3049,7 @@ var ItemTree = class ItemTree extends LibraryTree { } } - div.setAttribute('allowdrop', true); + div.dataset.allowdrop = true; } // My Publications else if (this.collectionTreeRow.isPublications()) { diff --git a/chrome/skin/default/zotero/overlay.css b/chrome/skin/default/zotero/overlay.css index 8283eacc3d..67571a05cd 100644 --- a/chrome/skin/default/zotero/overlay.css +++ b/chrome/skin/default/zotero/overlay.css @@ -153,16 +153,11 @@ flex-direction: column; justify-content: center; align-items: center; - width: calc(100% - 4em); - height: 100%; - position: absolute; - top: 0; - left: 2em; - right: 2em; + width: 100%; } .items-tree-message div { - padding: 0 35px; + padding: 0 65px; } .items-tree-message p {