mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fx-compat: Item box: Fix fieldMode resetting on blur

Browse source 
The fieldMode attribute of the input was being set by the call to
switchCreatorMode(), but it didn't carry over to the label that replaces it on
line 1997.

Also removed a debug line and cleaned up a bit.
This commit is contained in:
Abe Jellinek 2022-08-04 16:50:48 -04:00
parent 581f4bdf7b
commit 7a22458ed4
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
chrome/content/zotero/elements/itemBox.js
View file

@ -1033,12 +1033,11 @@
switchCreatorMode(row, fieldMode, initial, updatePref) {
// Change if button position changes
// row->hbox->label->label->toolbarbutton
var button = row.lastChild.lastChild.previousSibling.previousSibling;
var hbox = button.previousSibling;
var lastName = hbox.firstChild;
var comma = hbox.firstChild.nextSibling;
var firstName = hbox.lastChild;
var creatorNameBox = button.previousSibling;
var lastName = creatorNameBox.firstChild;
var comma = creatorNameBox.firstChild.nextSibling;
var firstName = creatorNameBox.lastChild;
// Switch to single-field mode
if (fieldMode == 1) {
@ -1918,10 +1917,8 @@
newVal = val;
// Reset creator mode settings here so that flex attribute gets reset
this.switchCreatorMode(row, (otherFields.fieldMode ? 1 : 0), true);
if (Zotero.ItemTypes.getName(this.item.itemTypeID) === "bookSection") {
var creatorTypeLabels = this.shadowRoot.querySelectorAll(".creator-type-label");
Zotero.debug(creatorTypeLabels[creatorTypeLabels.length-1] + "");
this._id("zotero-author-guidance").show({
forEl: creatorTypeLabels[creatorTypeLabels.length - 1]
});
@ -1997,12 +1994,15 @@
fieldName,
tabindex
);
var box = textbox.parentNode;
box.replaceChild(elem, textbox);
textbox.replaceWith(elem);
// Disassociate textbox from label
label.setAttribute('control', elem.getAttribute('id'));
if (field == 'creator') {
this.switchCreatorMode(row, (otherFields.fieldMode ? 1 : 0), true);
}
if (this.saveOnEdit) {
await this.item.saveTx();
}