mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix unloaded tab context menu actions

Browse source 
Show in Library and Move to New Window.

Will fix zotero/zotero#2685
This commit is contained in:
Abe Jellinek 2023-07-03 15:01:38 -04:00 • committed by Dan Stillman
parent 98fceea06d
commit 7791779289
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
chrome/content/zotero/tabs.js
View file

@ -498,9 +498,9 @@ var Zotero_Tabs = new function () {
menuitem = document.createXULElement('menuitem'); menuitem = document.createXULElement('menuitem');
menuitem.setAttribute('label', Zotero.getString('general.showInLibrary')); menuitem.setAttribute('label', Zotero.getString('general.showInLibrary'));
menuitem.addEventListener('command', () => { menuitem.addEventListener('command', () => {
var reader = Zotero.Reader.getByTabID(id); let { tab } = this._getTab(id);
if (reader) { if (tab && (tab.type === 'reader' || tab.type === 'reader-unloaded')) {
let itemID = reader.itemID; let itemID = tab.data.itemID;
let item = Zotero.Items.get(itemID); let item = Zotero.Items.get(itemID);
if (item && item.parentItemID) { if (item && item.parentItemID) {
itemID = item.parentItemID; itemID = item.parentItemID;
@ -537,11 +537,11 @@ var Zotero_Tabs = new function () {
menuitem.setAttribute('label', Zotero.getString('tabs.moveToWindow')); menuitem.setAttribute('label', Zotero.getString('tabs.moveToWindow'));
menuitem.setAttribute('disabled', false); menuitem.setAttribute('disabled', false);
menuitem.addEventListener('command', () => { menuitem.addEventListener('command', () => {
var reader = Zotero.Reader.getByTabID(id); let { tab } = this._getTab(id);
if (reader) { if (tab && (tab.type === 'reader' || tab.type === 'reader-unloaded')) {
this.close(id); this.close(id);
let { secondViewState } = tab.data; let { itemID, secondViewState } = tab.data;
Zotero.Reader.open(reader.itemID, null, { openInWindow: true, secondViewState }); Zotero.Reader.open(itemID, null, { openInWindow: true, secondViewState });
} }
}); });
menupopup.appendChild(menuitem); menupopup.appendChild(menuitem);