mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Require DB transaction in Zotero.Items.moveChildItems()

Browse source 
But make optional with deprecation warning for now, since it's used in
ZotFile
This commit is contained in:
Dan Stillman 2022-02-08 06:32:57 -05:00
parent f684984b07
commit 734057ff9b
1 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
chrome/content/zotero/xpcom/data/items.js
View file

@ -915,20 +915,32 @@ Zotero.Items = function() {
/** /**
* Move child items from one item to another * Move child items from one item to another
* *
* Requires a transaction
*
* @param {Zotero.Item} fromItem * @param {Zotero.Item} fromItem
* @param {Zotero.Item} toItem * @param {Zotero.Item} toItem
* @return {Promise} * @return {Promise}
*/ */
this.moveChildItems = async function (fromItem, toItem) { this.moveChildItems = async function (fromItem, toItem) {
//Zotero.DB.requireTransaction();
// Annotations on files // Annotations on files
if (fromItem.isFileAttachment()) { if (fromItem.isFileAttachment()) {
await Zotero.DB.executeTransaction(async function () { let fn = async function () {
let annotations = fromItem.getAnnotations(); let annotations = fromItem.getAnnotations();
for (let annotation of annotations) { for (let annotation of annotations) {
annotation.parentItemID = toItem.id; annotation.parentItemID = toItem.id;
await annotation.save(); await annotation.save();
};
};
if (!Zotero.DB.inTransaction) {
Zotero.logError("moveChildItems() now requires a transaction -- please update your code");
await Zotero.DB.executeTransaction(fn);
}
else {
await fn();
} }
}.bind(this));
} }
// TODO: Other things as necessary // TODO: Other things as necessary