mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Tweak recognizePDF fix, add test coverage, and enable manual tests

Browse source 
Still disabled in Travis until we mock the remote services
This commit is contained in:
Dan Stillman 2016-12-17 08:01:25 -05:00
parent e34bf4d5cb
commit 6994c63a0e
2 changed files with 16 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
chrome/content/zotero/xpcom/translation/translate_item.js
View file

@ -258,7 +258,7 @@ Zotero.Translate.ItemSaver.prototype = {
newAttachment = yield this._saveAttachmentFile.apply(this, arguments); newAttachment = yield this._saveAttachmentFile.apply(this, arguments);
} else { } else {
Zotero.debug('Translate: Ignoring attachment due to ATTACHMENT_MODE_IGNORE'); Zotero.debug('Translate: Ignoring attachment due to ATTACHMENT_MODE_IGNORE');
attachmentCallback(attachment, false, e); attachmentCallback(attachment, false);
return false; return false;
} }

19
test/tests/recognizePDFTest.js
View file

@ -1,4 +1,4 @@
describe.skip("PDF Recognition", function() { describe("PDF Recognition", function() {
var win; var win;
before(function* () { before(function* () {
@ -52,7 +52,7 @@ describe.skip("PDF Recognition", function() {
}); });
it("should recognize a PDF without a DOI", function* () { it("should recognize a PDF without a DOI", function* () {
if (Zotero.automatedTest) this.skip(); // CAPTCHAs make this fail if (Zotero.automatedTest) this.skip(); // TODO: Mock
this.timeout(30000); this.timeout(30000);
// Import the PDF // Import the PDF
@ -65,9 +65,20 @@ describe.skip("PDF Recognition", function() {
// Recognize the PDF // Recognize the PDF
win.Zotero_RecognizePDF.recognizeSelected(); win.Zotero_RecognizePDF.recognizeSelected();
var ids = yield waitForItemEvent("add"); var addedIDs = yield waitForItemEvent("add");
var item = Zotero.Items.get(ids[0]); var modifiedIDs = yield waitForItemEvent("modify");
assert.lengthOf(addedIDs, 1);
var item = Zotero.Items.get(addedIDs[0]);
assert.equal(item.getField("title"), "Scaling study of an improved fermion action on quenched lattices"); assert.equal(item.getField("title"), "Scaling study of an improved fermion action on quenched lattices");
assert.equal(item.getField("libraryCatalog"), "Google Scholar"); assert.equal(item.getField("libraryCatalog"), "Google Scholar");
assert.lengthOf(modifiedIDs, 2);
yield Zotero.Promise.delay(0);
var progressWindow = getWindows("chrome://zotero/content/pdfProgress.xul")[0];
assert.equal(
progressWindow.document.getElementById("label").value,
Zotero.getString("recognizePDF.complete.label")
);
}); });
}); });