mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Add annotationAuthorName property to annotation items

Browse source 
And pass both `authorName` and `lastCreatedByUser` to the PDF reader.
The former can either come from `createdByUser` or be set directly on
the item (for group annotations dragged to personal libraries).
This commit is contained in:
Dan Stillman 2022-02-08 04:33:33 -05:00
parent 60f9a0417f
commit 67451dffd5
6 changed files with 67 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

32
test/tests/annotationsTest.js
View file

@ -256,6 +256,38 @@ describe("Zotero.Annotations", function() {
skipEditCheck: true
});
});
it("should generate an object for a highlight by another user modified by the current user in a group library", async function () {
await Zotero.Users.setName(1, 'My Name');
await Zotero.Users.setName(12345, 'Their Name');
var annotation = await createAnnotation('highlight', groupAttachment);
annotation.createdByUserID = 12345;
annotation.lastModifiedByUserID = 1;
await annotation.saveTx({
skipEditCheck: true
});
var json = await Zotero.Annotations.toJSON(annotation);
assert.equal(json.authorName, 'Their Name');
assert.equal(json.lastModifiedByUser, 'My Name');
await annotation.eraseTx({
skipEditCheck: true
});
});
it("should generate an object for an annotation by another user in a personal library", async function () {
var annotation = await createAnnotation('highlight', attachment);
annotation.annotationAuthorName = 'First Last';
await annotation.saveTx();
var json = await Zotero.Annotations.toJSON(annotation);
assert.equal(json.authorName, 'First Last');
await annotation.eraseTx();
});
});