From 66fa9fdc51ec1cbc01a8b76c241d98340aca86d9 Mon Sep 17 00:00:00 2001 From: abaevbog Date: Mon, 8 Apr 2024 01:45:00 -0400 Subject: [PATCH] do not trigger event causing autocomplete error (#3925) DOMInputPasswordAdded event is triggered on autocomplete submission which causes an error in LoginManager. The error gets logged in the console, though the autocomplete does work. This just removes the event from ActorManagerParent. Fixes: #3883 --- app/scripts/fetch_xulrunner | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/scripts/fetch_xulrunner b/app/scripts/fetch_xulrunner index a1aced6103..b90c0003d9 100755 --- a/app/scripts/fetch_xulrunner +++ b/app/scripts/fetch_xulrunner @@ -82,7 +82,7 @@ function remove_line { egrep -v "$pattern" "$file" > "$file.tmp" mv "$file.tmp" "$file" else - echo "$pattern" not found in "$infile" -- aborting 2>&1 + echo "$pattern" not found in "$file" -- aborting 2>&1 exit 1 fi } @@ -164,6 +164,9 @@ function modify_omni { # Disable unwanted components remove_line '(RemoteSettings|services-|telemetry|Telemetry|URLDecorationAnnotationsService)' components/components.manifest + # Do not trigger LoginManager event that logs an error on autocomplete submission + remove_line 'DOMInputPasswordAdded: \{\},' modules/ActorManagerParent.sys.mjs + # On Mac/Linux, ignore relative paths in PATH in Subprocess.pathSearch(), used when a bare command is passed to Utilities.Internal.subprocess() if [[ $platform != win* ]]; then replace_line 'let path = PathUtils.join\(dir, bin\);' 'if (!dir.startsWith("\/")) continue; let path = PathUtils.join(dir, bin);' modules/subprocess/subprocess_unix.sys.mjs