mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Don't use RegExp for tag filter (Reactification regression)

Browse source 
Using a regexp meant that an invalid regexp pattern would crash the tag
selector, and even if we caught that it would produce unexpected results
for some searches (e.g., anything with a period).
This commit is contained in:
Dan Stillman 2019-03-20 07:12:48 -04:00
parent 42667e7090
commit 62ea7e970a
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
chrome/content/zotero/containers/tagSelector.jsx
View file

@ -170,7 +170,8 @@ Zotero.TagSelector = class TagSelectorContainer extends React.Component {
tags = Array.from(new Set(tags.map(t => t.tag)));
}
if (this.state.searchString) {
tags = tags.filter(tag => !!tag.match(new RegExp(this.state.searchString, 'i')));
let lcStr = this.state.searchString.toLowerCase();
tags = tags.filter(tag => tag.toLowerCase().startsWith(lcStr));
}
tags = tags.map((name) => {
return {