mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fx-compat: Fix some CE style conflicts

Browse source 
- Windows global styles make .header bold, so we'll override them
- Prefix IDs in <notes-box>
- Give <tags-box> Add button a normal margin
  - I think the CSS this removes was meant to apply to tags in the list, not the
    Add button, but that's handled elsewhere now
This commit is contained in:
Abe Jellinek 2023-04-05 12:39:32 -04:00
parent fcf3cec0fc
commit 5d44089214
3 changed files with 9 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
chrome/content/zotero-platform/win/overlay.css
View file

@ -119,10 +119,6 @@ tree {
padding-left: 0.05em; padding-left: 0.05em;
} }
#tags-box button {
margin: .04em 0 0 .15em !important;
}
.zotero-editpane-tabs spacer { .zotero-editpane-tabs spacer {
border: 0; border: 0;
} }

16
chrome/content/zotero/elements/notesBox.js
View file

@ -39,10 +39,10 @@
<box flex="1" style="display: flex" xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"> <box flex="1" style="display: flex" xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
<div style="flex-grow: 1" xmlns="http://www.w3.org/1999/xhtml"> <div style="flex-grow: 1" xmlns="http://www.w3.org/1999/xhtml">
<div class="header"> <div class="header">
<label id="num"/> <label id="notes-num"/>
<button id="add">&zotero.item.add;</button> <button id="notes-add">&zotero.item.add;</button>
</div> </div>
<div id="grid" class="grid"/> <div id="notes-grid" class="grid"/>
</div> </div>
</box> </box>
`, ['chrome://zotero/locale/zotero.dtd']); `, ['chrome://zotero/locale/zotero.dtd']);
@ -55,7 +55,7 @@
let content = document.importNode(this.content, true); let content = document.importNode(this.content, true);
this.append(content); this.append(content);
this._id('add').addEventListener('click', this._handleAdd); this._id('notes-add').addEventListener('click', this._handleAdd);
this._notifierID = Zotero.Notifier.registerObserver(this, ['item'], 'notesBox'); this._notifierID = Zotero.Notifier.registerObserver(this, ['item'], 'notesBox');
} }
@ -115,9 +115,9 @@
} }
this._noteIDs = this._item.getNotes(); this._noteIDs = this._item.getNotes();
this._id('add').hidden = this._mode != 'edit'; this._id('notes-add').hidden = this._mode != 'edit';
let grid = this._id('grid'); let grid = this._id('notes-grid');
grid.replaceChildren(); grid.replaceChildren();
let notes = Zotero.Items.get(this._item.getNotes()); let notes = Zotero.Items.get(this._item.getNotes());
@ -147,7 +147,7 @@
} }
let num = this._noteIDs.length; let num = this._noteIDs.length;
this._id('num').replaceChildren(Zotero.getString('pane.item.notes.count', num, num)); this._id('notes-num').replaceChildren(Zotero.getString('pane.item.notes.count', num, num));
} }
_handleAdd = (event) => { _handleAdd = (event) => {
@ -166,7 +166,7 @@
} }
_id(id) { _id(id) {
return this.querySelector(`[id=${id}]`); return this.querySelector(`#${id}`);
} }
} }
customElements.define("notes-box", NotesBox); customElements.define("notes-box", NotesBox);

1
scss/elements/_notesBox.scss
View file

@ -1,5 +1,6 @@
notes-box, related-box { notes-box, related-box {
.header { .header {
font-weight: normal;
display: flex; display: flex;
padding-left: 10px; padding-left: 10px;
align-items: center; align-items: center;