From 5c08e07bf5fa96ce91f93c1d99535670b724f7fc Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Tue, 9 Jul 2024 04:46:55 -0400 Subject: [PATCH] Don't expect return value from `renameSelectedAttachmentsFromParents()` Removed in da1599ca3402, because it was inconsistent and not actually meaningful --- test/tests/zoteroPaneTest.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/tests/zoteroPaneTest.js b/test/tests/zoteroPaneTest.js index c0e2b48f82..13c43ade52 100644 --- a/test/tests/zoteroPaneTest.js +++ b/test/tests/zoteroPaneTest.js @@ -591,7 +591,7 @@ describe("ZoteroPane", function() { }); await zp.selectItem(attachment.id); - await assert.eventually.isTrue(zp.renameSelectedAttachmentsFromParents()); + await zp.renameSelectedAttachmentsFromParents(); assert.equal(attachment.attachmentFilename, newFilename); var path = await attachment.getFilePathAsync(); assert.equal(OS.Path.basename(path), newFilename) @@ -620,7 +620,7 @@ describe("ZoteroPane", function() { }); await zp.selectItem(attachment.id); - await assert.eventually.isTrue(zp.renameSelectedAttachmentsFromParents()); + await zp.renameSelectedAttachmentsFromParents(); assert.equal(attachment.attachmentFilename, uniqueFilename); var path = await attachment.getFilePathAsync(); assert.equal(OS.Path.basename(path), uniqueFilename) @@ -649,7 +649,7 @@ describe("ZoteroPane", function() { }); await zp.selectItem(attachment.id); - await assert.eventually.isTrue(zp.renameSelectedAttachmentsFromParents()); + await zp.renameSelectedAttachmentsFromParents(); assert.equal(attachment.attachmentFilename, uniqueFilename); var path = await attachment.getFilePathAsync(); assert.equal(OS.Path.basename(path), uniqueFilename) @@ -666,7 +666,7 @@ describe("ZoteroPane", function() { await attachment.saveTx(); await zp.selectItem(attachment.id); - assert.isTrue(await zp.renameSelectedAttachmentsFromParents()); + await zp.renameSelectedAttachmentsFromParents(); assert.equal(attachment.attachmentFilename, 'Title.png'); assert.equal(attachment.getField('title'), 'Image') }); @@ -681,7 +681,7 @@ describe("ZoteroPane", function() { await attachment.saveTx(); await zp.selectItem(attachment.id); - assert.isTrue(await zp.renameSelectedAttachmentsFromParents()); + await zp.renameSelectedAttachmentsFromParents(); assert.equal(attachment.attachmentFilename, 'Title.png'); assert.equal(attachment.getField('title'), 'Title.png') }); @@ -696,7 +696,7 @@ describe("ZoteroPane", function() { await attachment.saveTx(); await zp.selectItem(attachment.id); - assert.isTrue(await zp.renameSelectedAttachmentsFromParents()); + await zp.renameSelectedAttachmentsFromParents(); assert.equal(attachment.attachmentFilename, 'Title.png'); assert.equal(attachment.getField('title'), 'Title.png') });