mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Enable PDF reader by default and enable for groups

Browse source 
"Zotero" is now the first and default option in the "Open PDFs using"
drop-down in the General pane of the preferences.
This commit is contained in:
Dan Stillman 2022-01-29 02:13:13 -05:00
parent f8d7eb8ed7
commit 5a0cd78f06
22 changed files with 84 additions and 263 deletions
Download patch file Download diff file Expand all files Collapse all files

21
test/tests/annotationsTest.js
View file

@ -126,14 +126,13 @@ describe("Zotero.Annotations", function() {
exampleNote.libraryID = item.libraryID;
exampleImage.libraryID = item.libraryID;
// Disabled while group annotations are disabled
/*group = await getGroup();
group = await getGroup();
exampleGroupHighlight.libraryID = group.libraryID;
groupItem = await createDataObject('item', { libraryID: group.libraryID });
groupAttachment = await importFileAttachment(
'test.pdf',
{ libraryID: group.libraryID, parentID: groupItem.id }
);*/
);
});
describe("#toJSON()", function () {
@ -236,11 +235,11 @@ describe("Zotero.Annotations", function() {
await annotation.eraseTx();
});
it.skip("should generate an object for a highlight by another user in a group library", async function () {
await Zotero.Users.setName(12345, 'Kate Smith');
it("should generate an object for a highlight by another user in a group library", async function () {
await Zotero.Users.setName(12345, 'First Last');
var annotation = new Zotero.Item('annotation');
annotation.libraryID = group.libraryID;
annotation.libraryID = groupAttachment.libraryID;
annotation.key = exampleGroupHighlight.key;
await annotation.loadPrimaryData();
annotation.createdByUserID = 12345;
@ -250,13 +249,17 @@ describe("Zotero.Annotations", function() {
let itemProp = 'annotation' + prop[0].toUpperCase() + prop.substr(1);
annotation[itemProp] = exampleGroupHighlightAlt[prop];
}
await annotation.saveTx();
await annotation.saveTx({
skipEditCheck: true
});
var json = await Zotero.Annotations.toJSON(annotation);
assert.isFalse(json.isAuthor);
assert.equal(json.authorName, 'Kate Smith');
assert.equal(json.authorName, 'First Last');
await annotation.eraseTx();
await annotation.eraseTx({
skipEditCheck: true
});
});
});