mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fix PDF reader keyboard navigation in RTL mode

Browse source
This commit is contained in:
Martynas Bagdonas 2022-03-14 17:25:28 +02:00
parent 3b8c16c155
commit 59caaf56ea
4 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
chrome/content/zotero/xpcom/reader.js
View file

@ -82,6 +82,7 @@ class ReaderInstance {
sidebarWidth: this._sidebarWidth, sidebarWidth: this._sidebarWidth,
sidebarOpen: this._sidebarOpen, sidebarOpen: this._sidebarOpen,
bottomPlaceholderHeight: this._bottomPlaceholderHeight, bottomPlaceholderHeight: this._bottomPlaceholderHeight,
rtl: Zotero.rtl,
localizedStrings: { localizedStrings: {
...Zotero.Intl.getPrefixedStrings('general.'), ...Zotero.Intl.getPrefixedStrings('general.'),
...Zotero.Intl.getPrefixedStrings('pdfReader.') ...Zotero.Intl.getPrefixedStrings('pdfReader.')

6
chrome/content/zotero/zoteroPane.js
View file

@ -519,12 +519,14 @@ var ZoteroPane = new function()
let itemPaneToggle = document.getElementById('zotero-tb-toggle-item-pane'); let itemPaneToggle = document.getElementById('zotero-tb-toggle-item-pane');
let notesPaneToggle = document.getElementById('zotero-tb-toggle-notes-pane'); let notesPaneToggle = document.getElementById('zotero-tb-toggle-notes-pane');
// Using ArrowDown and ArrowUp to be consistent with pdf-reader // Using ArrowDown and ArrowUp to be consistent with pdf-reader
if (event.key === 'ArrowRight' || event.key === 'ArrowDown') { if (!Zotero.rtl && (event.key === 'ArrowRight' || event.key === 'ArrowDown')
|| Zotero.rtl && (event.key === 'ArrowLeft' || event.key === 'ArrowUp')) {
if (event.target === itemPaneToggle) { if (event.target === itemPaneToggle) {
notesPaneToggle.focus(); notesPaneToggle.focus();
} }
} }
else if (event.key === 'ArrowLeft' || event.key === 'ArrowUp') { else if (!Zotero.rtl && (event.key === 'ArrowLeft' || event.key === 'ArrowUp')
|| Zotero.rtl && (event.key === 'ArrowRight' || event.key === 'ArrowDown')) {
if (event.target === notesPaneToggle) { if (event.target === notesPaneToggle) {
itemPaneToggle.focus(); itemPaneToggle.focus();
} }

2
note-editor

@ -1 +1 @@
Subproject commit a3f0ea4ac9077235fa4197a51375516072496a72 Subproject commit 7690fdc9f78d65353215d48a71a1bf6e31f8c47d

2
pdf-reader

@ -1 +1 @@
Subproject commit cc517ae53bd849e7dc3a958b156552117d209e53 Subproject commit 702fd99ca58801be27b25ee550331b9615f27184