mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Don't limit PDF retrieval to dev builds

Browse source
This commit is contained in:
Dan Stillman 2018-08-25 17:00:53 -04:00
parent 862ac5ab40
commit 4eb4490723
3 changed files with 5 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
chrome/content/zotero/lookup.js
View file

@ -72,9 +72,7 @@ var Zotero_Lookup = new function () {
// If we don't yet have a file, check for available PDFs // If we don't yet have a file, check for available PDFs
if (Zotero.Prefs.get('downloadAssociatedFiles') if (Zotero.Prefs.get('downloadAssociatedFiles')
&& newItems[0] && newItems[0]
&& !newItems[0].numPDFAttachments() && !newItems[0].numPDFAttachments()) {
// TEMP: Limit to dev builds
&& Zotero.isDevBuild) {
try { try {
yield Zotero.Attachments.addAvailablePDF(newItems[0]); yield Zotero.Attachments.addAvailablePDF(newItems[0]);
} }

8
chrome/content/zotero/xpcom/translation/translate_item.js
View file

@ -198,9 +198,7 @@ Zotero.Translate.ItemSaver.prototype = {
// TODO: Separate pref? // TODO: Separate pref?
var openAccessPDFURLs = new Map(); var openAccessPDFURLs = new Map();
if (this.attachmentMode == Zotero.Translate.ItemSaver.ATTACHMENT_MODE_DOWNLOAD if (this.attachmentMode == Zotero.Translate.ItemSaver.ATTACHMENT_MODE_DOWNLOAD
&& Zotero.Prefs.get('downloadAssociatedFiles') && Zotero.Prefs.get('downloadAssociatedFiles')) {
// TEMP: Limit to dev builds
&& Zotero.isDevBuild) {
for (let item of items) { for (let item of items) {
let jsonItem = jsonByItem.get(item); let jsonItem = jsonByItem.get(item);
@ -255,9 +253,7 @@ Zotero.Translate.ItemSaver.prototype = {
// If a translated PDF attachment wasn't saved successfully, either because there wasn't // If a translated PDF attachment wasn't saved successfully, either because there wasn't
// one or there was but it failed, look for another PDF (if enabled) // one or there was but it failed, look for another PDF (if enabled)
if (this.attachmentMode == Zotero.Translate.ItemSaver.ATTACHMENT_MODE_DOWNLOAD if (this.attachmentMode == Zotero.Translate.ItemSaver.ATTACHMENT_MODE_DOWNLOAD
&& Zotero.Prefs.get('downloadAssociatedFiles') && Zotero.Prefs.get('downloadAssociatedFiles')) {
// TEMP: Limit to dev builds
&& Zotero.isDevBuild) {
for (let item of items) { for (let item of items) {
// Already have a PDF from translation // Already have a PDF from translation
if (itemIDsWithPDFAttachments.has(item.id)) { if (itemIDsWithPDFAttachments.has(item.id)) {

6
chrome/content/zotero/zoteroPane.js
View file

@ -2843,8 +2843,7 @@ var ZoteroPane = new function()
} }
} }
// TEMP: Limit to dev builds if (canFindPDF) {
if (canFindPDF && Zotero.isDevBuild) {
show.push(m.findPDF, m.sep3); show.push(m.findPDF, m.sep3);
} }
@ -2903,8 +2902,7 @@ var ZoteroPane = new function()
show.push(m.addNote, m.addAttachments, m.sep2); show.push(m.addNote, m.addAttachments, m.sep2);
} }
// TEMP: Limit to dev builds if (Zotero.Attachments.canFindPDFForItem(item)) {
if (Zotero.Attachments.canFindPDFForItem(item) && Zotero.isDevBuild) {
show.push(m.findPDF, m.sep3); show.push(m.findPDF, m.sep3);
} }