mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Remove tags on shift-drag

Browse source 
Closes #852

Currently shows a *+* icon for adding a tag and
a *link* icon for removing it.

There does not appear to be any way to have a custom mouse cursor,
which makes this interaction extremely unintuitive. It might be
possible to hack this in, but it does not really warrant the effort.
E.g. `window.setCursor` does not respond whilst dragging.
This commit is contained in:
Adomas Venčkauskas 2015-11-18 18:05:57 +00:00
parent 08cb63f66d
commit 4b16210ac6
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
chrome/content/zotero/bindings/tagselector.xml
View file

@ -934,13 +934,16 @@
} }
} }
*/ */
// Store the event, because drop event does not have shiftKey attribute set
Zotero.DragDrop.currentEvent = event;
event.target.setAttribute('draggedOver', true); event.target.setAttribute('draggedOver', true);
event.preventDefault(); event.preventDefault();
event.effectAllowed = event.dropEffect = "link"; event.dataTransfer.dropEffect = "copy";
} }
this.onDragExit = function (event) { this.onDragExit = function (event) {
Zotero.DragDrop.currentEvent = null;
event.target.setAttribute('draggedOver', false); event.target.setAttribute('draggedOver', false);
} }
@ -962,7 +965,11 @@
for (let i=0; i<items.length; i++) { for (let i=0; i<items.length; i++) {
let item = items[i]; let item = items[i];
item.addTag(value); if (Zotero.DragDrop.currentEvent.shiftKey) {
item.removeTag(value);
} else {
item.addTag(value);
}
yield item.save(); yield item.save();
} }
}.bind(this)); }.bind(this));