From 4ac35ecda3160e9d4f75a119edff09fde4db3f5d Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Wed, 9 Sep 2020 23:10:25 -0400 Subject: [PATCH] Fix invalid HTML in note from Quick Copy A was included with the note element outside of it. --- chrome/content/zotero/xpcom/quickCopy.js | 16 +++++++++------- test/tests/quickCopyTest.js | 11 +++++++++++ 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/chrome/content/zotero/xpcom/quickCopy.js b/chrome/content/zotero/xpcom/quickCopy.js index 258c94bab8..647a029810 100644 --- a/chrome/content/zotero/xpcom/quickCopy.js +++ b/chrome/content/zotero/xpcom/quickCopy.js @@ -278,13 +278,15 @@ Zotero.QuickCopy = new function() { // If all notes, export full content if (allNotes) { - var content = [], - parser = Components.classes["@mozilla.org/xmlextras/domparser;1"] - .createInstance(Components.interfaces.nsIDOMParser), - doc = parser.parseFromString('
', 'text/html'), - textDoc = parser.parseFromString('
', 'text/html'), - container = doc.documentElement, - textContainer = textDoc.documentElement; + var content = []; + let parser = Components.classes["@mozilla.org/xmlextras/domparser;1"] + .createInstance(Components.interfaces.nsIDOMParser); + let docHTML = '
'; + let doc = parser.parseFromString(docHTML, 'text/html'); + let textDoc = parser.parseFromString(docHTML, 'text/html'); + let container = doc.body.firstChild; + let textContainer = textDoc.body.firstChild; + for (var i=0; iFoo

' }); + + var format = 'bibliography=http://www.zotero.org/styles/apa'; + Zotero.Prefs.set(prefName, format); + + var content = Zotero.QuickCopy.getContentFromItems([item], format); + assert.propertyVal(content, 'text', 'Foo'); + assert.propertyVal(content, 'html', '

Foo

'); + }); }); it("should generate bibliography in default locale if Quick Copy locale not set", async function () {