mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fx-compat: Item box: Fix abstract expander

Browse source
This commit is contained in:
Abe Jellinek 2022-05-25 13:22:52 -06:00
parent 3566d1fc1f
commit 4a856b94cc
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
chrome/content/zotero/elements/itemBox.js
View file

@ -585,7 +585,7 @@
} }
else { else {
this.getRootNode().host.toggleAbstractExpand( this.getRootNode().host.toggleAbstractExpand(
this, this.closest('tr').querySelector('.value') this.firstElementChild, this.closest('tr').querySelector('.value')
); );
} }
}); });
@ -1264,14 +1264,14 @@
'abstractNote', 'abstractNote',
tabindex tabindex
); );
valueElement.parentNode.replaceChild(newValueElement, valueElement); valueElement.replaceWith(newValueElement);
var text = Zotero.ItemFields.getLocalizedString('abstractNote'); var text = Zotero.ItemFields.getLocalizedString('abstractNote');
// Add '(...)' before "Abstract" for collapsed abstracts // Add '(...)' before "Abstract" for collapsed abstracts
if (valueText && cur) { if (valueText && cur) {
text = '(\u2026) ' + text; text = '(\u2026) ' + text;
} }
label.setAttribute('value', text); label.textContent = text;
} }
disableButton(button) { disableButton(button) {
@ -1401,23 +1401,25 @@
valueElement.textContent = valueText; valueElement.textContent = valueText;
if (isMultiline) {
valueElement.classList.add('multiline');
}
if ((firstSpace == -1 && valueText.length > 29) || firstSpace > 29 if ((firstSpace == -1 && valueText.length > 29) || firstSpace > 29
|| (fieldName && || (fieldName &&
(fieldName.substr(0, 7) == 'creator') || fieldName == 'abstractNote')) { (fieldName.startsWith('creator') || (!isMultiline && fieldName == 'abstractNote')))) {
if (fieldName == 'abstractNote') { if (fieldName == 'abstractNote') {
valueText = valueText.replace(/[\t\n]/g, ' '); valueText = valueText.replace(/[\t\n]/g, ' ');
} }
valueElement.setAttribute('crop', 'end'); valueElement.setAttribute('crop', 'end');
} }
else if (isMultiline) {
valueElement.classList.add('multiline');
}
// Allow toggling non-editable Abstract open and closed with click // Allow toggling non-editable Abstract open and closed with click
if (fieldName == 'abstractNote' && !this.editable) { if (fieldName == 'abstractNote' && !this.editable) {
valueElement.classList.add("pointer"); valueElement.classList.add("pointer");
valueElement.addEventListener('click', () => { valueElement.addEventListener('click', () => {
this.toggleAbstractExpand(valueElement.previousSibling, valueElement); let label = valueElement.parentElement.previousElementSibling.firstElementChild;
this.toggleAbstractExpand(label, valueElement);
}); });
} }