mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Remove non-matching parent items when deleting items from trash

Browse source 
Fixes #866, Trash doesn't refresh properly when emptying deleted
attachments
This commit is contained in:
Dan Stillman 2017-07-26 05:31:39 -04:00
parent 81d5618346
commit 46531a4c69
4 changed files with 45 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

17
test/tests/itemTreeViewTest.js
View file

@ -530,6 +530,23 @@ describe("Zotero.ItemTreeView", function() {
assert.isFalse(zp.itemsView.getRowIndexByID(item.id));
});
describe("Trash", function () {
it("should remove untrashed parent item when last trashed child is deleted", function* () {
var userLibraryID = Zotero.Libraries.userLibraryID;
var item = yield createDataObject('item');
var note = yield createDataObject(
'item', { itemType: 'note', parentID: item.id, deleted: true }
);
yield cv.selectByID("T" + userLibraryID);
yield waitForItemsLoad(win);
assert.isNumber(zp.itemsView.getRowIndexByID(item.id));
var promise = waitForDialog();
yield zp.emptyTrash();
yield promise;
assert.isFalse(zp.itemsView.getRowIndexByID(item.id));
});
});
describe("My Publications", function () {
before(function* () {
var libraryID = Zotero.Libraries.userLibraryID;