mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fixes #61, creator caching sometimes malfunctions

Browse source
This commit is contained in:
Dan Stillman 2006-06-23 22:00:39 +00:00
parent 6f19b215f5
commit 42578ace59
1 changed files with 10 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
chrome/chromeFiles/content/scholar/xpcom/data_access.js
View file

@ -467,12 +467,8 @@ Scholar.Item.prototype.save = function(){
}
}
// Append the SQL to delete obsolete creators
//
// TODO: fix this so it actually purges the internal memory
if (sql = Scholar.Creators.purge(true)){
Scholar.DB.query(sql);
}
// Delete obsolete creators
Scholar.Creators.purge();
}
@ -1680,22 +1676,15 @@ Scholar.Creators = new function(){
/*
* Delete obsolete creators from database and clear internal array entries
*
* Returns TRUE on success, or SQL query to run in returnSQL mode
* Returns removed creatorIDs on success
*/
function purge(returnSQL){
function purge(){
var sql = 'SELECT creatorID FROM creators WHERE creatorID NOT IN '
+ '(SELECT creatorID FROM itemCreators);';
var toDelete = Scholar.DB.columnQuery(sql);
if (!toDelete){
return returnSQL ? '' : false;
}
sql = 'DELETE FROM creators WHERE creatorID NOT IN '
+ '(SELECT creatorID FROM itemCreators);';
if (!returnSQL){
var result = Scholar.DB.query(sql);
return false;
}
// Clear creator entries in internal array
@ -1705,7 +1694,11 @@ Scholar.Creators = new function(){
delete _creatorsByID[toDelete[i]];
}
return returnSQL ? sql : result;
sql = 'DELETE FROM creators WHERE creatorID NOT IN '
+ '(SELECT creatorID FROM itemCreators);';
var result = Scholar.DB.query(sql);
return toDelete;
}