mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix Scholar.getItems() to not trigger an SQL query for every item

Browse source
This commit is contained in:
Dan Stillman 2006-06-06 19:06:40 +00:00
parent 152c9bf9e7
commit 3aae8d3f89
1 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
chrome/chromeFiles/content/scholar/xpcom/data_access.js
View file

@ -802,6 +802,7 @@ Scholar.Items = new function(){
var loaded = new Array(); var loaded = new Array();
if (!arguments[0]){ if (!arguments[0]){
Scholar.debug('No arguments provided to Items.get()');
return false; return false;
} }
@ -820,7 +821,7 @@ Scholar.Items = new function(){
} }
// If single id, return the object directly // If single id, return the object directly
if (arguments[0] && typeof arguments[0]!='Object' if (arguments[0] && typeof arguments[0]!='object'
&& typeof arguments[1]=='undefined'){ && typeof arguments[1]=='undefined'){
return _items[arguments[0]]; return _items[arguments[0]];
} }
@ -944,7 +945,6 @@ Scholar.Items = new function(){
+ 'LEFT JOIN creators C ON (IC.creatorID=C.creatorID) ' + 'LEFT JOIN creators C ON (IC.creatorID=C.creatorID) '
+ 'WHERE (IC.orderIndex=0 OR IC.orderIndex IS NULL)'; + 'WHERE (IC.orderIndex=0 OR IC.orderIndex IS NULL)';
Scholar.debug(arguments[0]);
if (arguments[0]){ if (arguments[0]){
sql += ' AND I.itemID IN (' + Scholar.join(arguments,',') + ')'; sql += ' AND I.itemID IN (' + Scholar.join(arguments,',') + ')';
} }
@ -1828,13 +1828,11 @@ Scholar.getItems = function(parent){
return toReturn; return toReturn;
} }
// Items.get() returns an array indexed by itemID,
// so we have to turn it into a regular numeric array from 0
var items = Scholar.Items.get(children)
for (var i=0, len=children.length; i<len; i++){ for (var i=0, len=children.length; i<len; i++){
var obj = Scholar.Items.get(children[i]); toReturn.push(items[children[i]]);
if (!obj){
throw ('Item ' + children[i] + ' not found');
}
toReturn.push(obj);
} }
return toReturn; return toReturn;