mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Mark trashed items as unsynced and update parents (including note list)

Browse source 
Regression from 3a0e0cb088
This commit is contained in:
Dan Stillman 2017-02-15 13:15:30 -05:00
parent 41538ebca6
commit 3830aa1125
5 changed files with 86 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

27
test/tests/itemsTest.js
View file

@ -92,19 +92,38 @@ describe("Zotero.Items", function () {
it("should send items to the trash", function* () {
var items = [];
items.push(
(yield createDataObject('item')),
(yield createDataObject('item')),
(yield createDataObject('item'))
(yield createDataObject('item', { synced: true })),
(yield createDataObject('item', { synced: true })),
(yield createDataObject('item', { synced: true }))
);
items.forEach(item => {
// Sanity-checked as true in itemTest#deleted
assert.isUndefined(item._changed.deleted);
});
var ids = items.map(item => item.id);
yield Zotero.Items.trashTx(ids);
items.forEach(item => {
assert.isTrue(item.deleted);
assert.isFalse(item.hasChanged());
// Item should be saved (can't use hasChanged() because that includes .synced)
assert.isUndefined(item._changed.deleted);
assert.isFalse(item.synced);
});
assert.equal((yield Zotero.DB.valueQueryAsync(
`SELECT COUNT(*) FROM deletedItems WHERE itemID IN (${ids})`
)), 3);
for (let item of items) {
assert.equal((yield Zotero.DB.valueQueryAsync(
`SELECT synced FROM items WHERE itemID=${item.id}`
)), 0);
}
});
it("should update parent item when trashing child item", function* () {
var item = yield createDataObject('item');
var note = yield createDataObject('item', { itemType: 'note', parentID: item.id });
assert.lengthOf(item.getNotes(), 1);
yield Zotero.Items.trashTx([note.id]);
assert.lengthOf(item.getNotes(), 0);
});
});