mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

- Send a 'modify' to collections in addItem() and removeItem() when collections become or stop being empty

Browse source 
- Send a 'delete' rather than a 'remove' to itemViews when items are actually deleted (removals from collections still get 'remove' unless it's part of a collection erase)
This commit is contained in:
Dan Stillman 2006-06-08 20:41:37 +00:00
parent 368724b7de
commit 3715f2c89e
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
chrome/chromeFiles/content/scholar/xpcom/data_access.js
View file

@ -712,7 +712,7 @@ Scholar.Item.prototype.erase = function(){
// If we're not in the middle of a larger commit, trigger the notifier now
if (!Scholar.DB.transactionInProgress()){
Scholar.Notifier.trigger('remove', 'item', this.getID());
Scholar.Notifier.trigger('delete', 'item', this.getID());
}
}
@ -1189,7 +1189,12 @@ Scholar.Collection.prototype.addItem = function(itemID){
Scholar.DB.commitTransaction();
this._childItems.set(itemID);
this._hasChildItems = true;
// If this was previously empty, update and send a notification to the tree
if (!this._hasChildItems){
this._hasChildItems = true;
Scholar.Notifier.trigger('modify', 'collections', this.getID());
}
Scholar.Notifier.trigger('add', 'item', itemID);
}
@ -1228,6 +1233,7 @@ Scholar.Collection.prototype.removeItem = function(itemID){
// If this was the last item, set collection to empty
if (!this._childItems.length){
this._hasChildItems = false;
Scholar.Notifier.trigger('modify', 'collections', this.getID());
}
Scholar.Notifier.trigger('remove', 'item', itemID);
@ -1299,7 +1305,7 @@ Scholar.Collection.prototype.erase = function(deleteItems){
Scholar.Notifier.trigger('remove', 'collection', collections);
if (items.length){
Scholar.Notifier.trigger('remove', 'item', items);
Scholar.Notifier.trigger('delete', 'item', items);
}
}