mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Don't select sibling on attachment removal if attachment was unselected

Browse source 
Fixes #1173
This commit is contained in:
Dan Stillman 2017-02-21 01:21:07 -05:00
parent 60b2e16746
commit 333675d8ea
2 changed files with 14 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
test/tests/itemTreeViewTest.js
View file

@ -269,7 +269,17 @@ describe("Zotero.ItemTreeView", function() {
assert.equal(itemsView.selection.currentIndex, 2);
yield Zotero.Items.erase(items.map(item => item.id));
})
});
it("shouldn't select sibling on attachment erase if attachment wasn't selected", function* () {
var item = yield createDataObject('item');
var att1 = yield importFileAttachment('test.png', { title: 'A', parentItemID: item.id });
var att2 = yield importFileAttachment('test.png', { title: 'B', parentItemID: item.id });
yield zp.itemsView.selectItem(att2.id); // expand
yield zp.itemsView.selectItem(item.id);
yield att1.eraseTx();
assert.sameMembers(zp.itemsView.getSelectedItems(true), [item.id]);
});
it("should keep first visible item in view when other items are added with skipSelect and nothing in view is selected", function* () {
var collection = yield createDataObject('collection');