mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix removal of creators when changing to item type without creators

Browse source 
This shouldn't actually be used currently, since only notes and
attachments lack creators and it shouldn't be possible to change regular
items into notes or attachments.
This commit is contained in:
Dan Stillman 2020-03-17 12:01:34 -04:00
parent c4aad9a041
commit 3247391914
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
chrome/content/zotero/xpcom/data/item.js
View file

@ -499,10 +499,11 @@ Zotero.Item.prototype.setType = function(itemTypeID, loadIn) {
let creators = this.getCreators(); let creators = this.getCreators();
if (creators.length) { if (creators.length) {
let removeAll = !Zotero.CreatorTypes.itemTypeHasCreators(itemTypeID); let removeAll = !Zotero.CreatorTypes.itemTypeHasCreators(itemTypeID);
for (let i=0; i<creators.length; i++) { for (let i = 0; i < this.getCreators().length; i++) {
// Remove all creators if new item type doesn't have any // Remove all creators if new item type doesn't have any
if (removeAll) { if (removeAll) {
this.removeCreator(i); this.removeCreator(i);
i--;
continue; continue;
} }