mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

- Zotero.Translate.Import#getTranslators should return translators when they are available

Browse source 
- Add deprecation warning for select handler without a callback
This commit is contained in:
Simon Kornblith 2011-07-12 04:34:06 +00:00
parent 4d307c1865
commit 3238656ca0
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
chrome/content/zotero/xpcom/translation/translate.js
View file

@ -425,6 +425,10 @@ Zotero.Translate.Sandbox = {
var returnValue = translate._runHandler("select", items, newCallback); var returnValue = translate._runHandler("select", items, newCallback);
if(returnValue !== undefined) { if(returnValue !== undefined) {
// handler may have returned a value, which makes callback unnecessary // handler may have returned a value, which makes callback unnecessary
Zotero.debug("WARNING: Returning items from a select handler is deprecated. "+
"Please pass items as to the callback provided as the third argument to "+
"the handler.");
returnedItems = returnValue; returnedItems = returnValue;
haveAsyncHandler = false; haveAsyncHandler = false;
} else { } else {
@ -1520,7 +1524,7 @@ Zotero.Translate.Import.prototype.getTranslators = function() {
}); });
if(this._currentState === null) return this._foundTranslators; if(this._currentState === null) return this._foundTranslators;
} else { } else {
Zotero.Translate.Base.prototype.getTranslators.call(this); return Zotero.Translate.Base.prototype.getTranslators.call(this);
} }
} }