From 2ff67c987ef47d9d2d5d2e6c0bf9dfee2a21e1ca Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Fri, 8 Jul 2022 06:44:10 -0400 Subject: [PATCH] Fix test failure after a8ed30ce8 We added a `toggleSort()` call on the title, so then when called again it reverses the direction. To avoid, sort by creator and then title in the second test. --- test/tests/itemTreeTest.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/tests/itemTreeTest.js b/test/tests/itemTreeTest.js index ddbdde1c32..7a57479067 100644 --- a/test/tests/itemTreeTest.js +++ b/test/tests/itemTreeTest.js @@ -616,7 +616,10 @@ describe("Zotero.ItemTree", function() { var item3 = await createDataObject('item', { title: title + " 5" }); var item4 = await createDataObject('item', { title: title + " 7" }); - const colIndex = itemsView.tree._getColumns().findIndex(column => column.dataKey == 'title'); + // Sort by creator and then title, to make sure we're sorting by title ascending + var colIndex = itemsView.tree._getColumns().findIndex(column => column.dataKey == 'firstCreator'); + await itemsView.tree._columns.toggleSort(colIndex); + colIndex = itemsView.tree._getColumns().findIndex(column => column.dataKey == 'title'); await itemsView.tree._columns.toggleSort(colIndex); // Check initial sort order