mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Make attachment post-process failures non-fatal

Browse source 
This is generally just detecting the character set and/or indexing, so
it's not the end of the world if it fails.
This commit is contained in:
Dan Stillman 2018-06-19 18:25:53 -04:00
parent 2a7f31813e
commit 2d6332212c
1 changed files with 23 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

31
chrome/content/zotero/xpcom/attachments.js
View file

@ -117,7 +117,12 @@ Zotero.Attachments = new function(){
attachmentItem.attachmentPath = newFile.path; attachmentItem.attachmentPath = newFile.path;
yield attachmentItem.save(saveOptions); yield attachmentItem.save(saveOptions);
}.bind(this)); }.bind(this));
yield _postProcessFile(attachmentItem, newFile, contentType); try {
yield _postProcessFile(attachmentItem, newFile, contentType);
}
catch (e) {
Zotero.logError(e);
}
} }
catch (e) { catch (e) {
Zotero.logError(e); Zotero.logError(e);
@ -170,7 +175,12 @@ Zotero.Attachments = new function(){
collections, collections,
saveOptions saveOptions
}); });
yield _postProcessFile(item, file, contentType); try {
yield _postProcessFile(item, file, contentType);
}
catch (e) {
Zotero.logError(e);
}
return item; return item;
}); });
@ -232,12 +242,17 @@ Zotero.Attachments = new function(){
file.parent.copyTo(storageDir, destDir.leafName); file.parent.copyTo(storageDir, destDir.leafName);
} }
}.bind(this)); }.bind(this));
yield _postProcessFile( try {
attachmentItem, yield _postProcessFile(
Zotero.File.pathToFile(newPath), attachmentItem,
contentType, Zotero.File.pathToFile(newPath),
charset contentType,
); charset
);
}
catch (e) {
Zotero.logError(e);
}
} }
catch (e) { catch (e) {
Zotero.logError(e); Zotero.logError(e);