mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Add "Show developer tools" option to Advanced prefs

Browse source 
And move Error Console and Run JavaScript to a Developer menu that's
shown in Tools if that option is enabled.

The Memory Info button is now behind its own undefined
extensions.zotero.debug.memoryInfo pref.
This commit is contained in:
Dan Stillman 2019-08-02 02:56:26 -04:00
parent fda002ec34
commit 2a3c4a3555
4 changed files with 28 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
chrome/content/zotero/preferences/preferences_advanced.js
View file

@ -32,8 +32,8 @@ Zotero_Preferences.Advanced = {
init: function () { init: function () {
Zotero_Preferences.Keys.init(); Zotero_Preferences.Keys.init();
// Show Memory Info button if the Error Console menu option is enabled // Show Memory Info button
if (Zotero.Prefs.get('devtools.errorconsole.enabled', true)) { if (Zotero.Prefs.get('debug.memoryInfo')) {
document.getElementById('memory-info').hidden = false; document.getElementById('memory-info').hidden = false;
} }
@ -64,6 +64,14 @@ Zotero_Preferences.Advanced = {
}), }),
onDeveloperToolsToggle: function () {
setTimeout(function () {
var enabled = Zotero.Prefs.get('devtools.chrome.enabled', true);
window.opener.document.getElementById('developer-menu').hidden = !enabled;
});
},
migrateDataDirectory: Zotero.Promise.coroutine(function* () { migrateDataDirectory: Zotero.Promise.coroutine(function* () {
var currentDir = Zotero.DataDirectory.dir; var currentDir = Zotero.DataDirectory.dir;
var defaultDir = Zotero.DataDirectory.defaultDir; var defaultDir = Zotero.DataDirectory.defaultDir;

9
chrome/content/zotero/preferences/preferences_advanced.xul
View file

@ -39,6 +39,7 @@
<preferences> <preferences>
<preference id="pref-automaticScraperUpdates" name="extensions.zotero.automaticScraperUpdates" type="bool"/> <preference id="pref-automaticScraperUpdates" name="extensions.zotero.automaticScraperUpdates" type="bool"/>
<preference id="pref-reportTranslationFailure" name="extensions.zotero.reportTranslationFailure" type="bool"/> <preference id="pref-reportTranslationFailure" name="extensions.zotero.reportTranslationFailure" type="bool"/>
<preference id="pref-developerTools" name="devtools.chrome.enabled" type="bool"/>
<preference id="pref-baseAttachmentPath" name="extensions.zotero.baseAttachmentPath" type="string"/> <preference id="pref-baseAttachmentPath" name="extensions.zotero.baseAttachmentPath" type="string"/>
<preference id="pref-useDataDir" name="extensions.zotero.useDataDir" type="bool"/> <preference id="pref-useDataDir" name="extensions.zotero.useDataDir" type="bool"/>
@ -135,6 +136,14 @@
<groupbox id="zotero-prefpane-advanced-advancedConfiguration"> <groupbox id="zotero-prefpane-advanced-advancedConfiguration">
<caption label="&zotero.preferences.advanced.advancedConfiguration;"/> <caption label="&zotero.preferences.advanced.advancedConfiguration;"/>
<vbox>
<checkbox
label="Show developer tools"
preference="pref-developerTools"
oncommand="Zotero_Preferences.Advanced.onDeveloperToolsToggle()"
tooltiptext="Adds a Developer menu to the Tools menu"/>
</vbox>
<hbox id="zotero-prefpane-advanced-openbuttons" align="center" style="display: block"> <hbox id="zotero-prefpane-advanced-openbuttons" align="center" style="display: block">
<button id="config-editor" <button id="config-editor"
label="&zotero.preferences.configEditor;" label="&zotero.preferences.configEditor;"

6
chrome/content/zotero/standalone/standalone.js
View file

@ -48,12 +48,8 @@ const ZoteroStandalone = new function() {
return Zotero.initializationPromise; return Zotero.initializationPromise;
}) })
.then(async function () { .then(async function () {
if (Zotero.Prefs.get('devtools.errorconsole.enabled', true)) {
document.getElementById('menu_errorConsole').hidden = false;
}
if (Zotero.Prefs.get('devtools.chrome.enabled', true)) { if (Zotero.Prefs.get('devtools.chrome.enabled', true)) {
document.getElementById('menu_errorConsole').hidden = false; document.getElementById('developer-menu').hidden = false;
document.getElementById('menu_runJS').hidden = false;
} }
document.getElementById('key_copyCitation') document.getElementById('key_copyCitation')

10
chrome/content/zotero/standalone/standalone.xul
View file

@ -197,8 +197,14 @@
oncommand="ZoteroStandalone.openHelp('connectors');"/> oncommand="ZoteroStandalone.openHelp('connectors');"/>
<menuitem id="menu_addons" label="&addons.label;" <menuitem id="menu_addons" label="&addons.label;"
oncommand="Zotero.openInViewer('chrome://mozapps/content/extensions/extensions.xul', ZoteroStandalone.updateAddonsPane)"/> oncommand="Zotero.openInViewer('chrome://mozapps/content/extensions/extensions.xul', ZoteroStandalone.updateAddonsPane)"/>
<menuitem id="menu_errorConsole" label="Error Console" oncommand="toJavaScriptConsole()" hidden="true"/> <menu id="developer-menu"
<menuitem id="menu_runJS" label="Run JavaScript" oncommand="openRunJSWindow()" hidden="true"/> label="Developer"
hidden="true">
<menupopup>
<menuitem id="menu_errorConsole" label="Error Console" oncommand="toJavaScriptConsole()"/>
<menuitem id="menu_runJS" label="Run JavaScript" oncommand="openRunJSWindow()"/>
</menupopup>
</menu>
</menupopup> </menupopup>
</menu> </menu>