mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Block remote content when indexing HTML file (#3157)

Browse source
This commit is contained in:
Abe Jellinek 2023-06-12 23:43:18 -04:00 • committed by GitHub
parent 30624c6aba
commit 2639981dda
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 75 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

34
test/tests/HiddenBrowserTest.js
View file

@ -7,12 +7,30 @@ describe("HiddenBrowser", function() {
var httpd;
var port = 16213;
var baseURL = `http://127.0.0.1:${port}/`;
var pngRequested = false;
before(function () {
Cu.import("resource://zotero-unit/httpd.js");
httpd = new HttpServer();
httpd.start(port);
});
beforeEach(async function () {
pngRequested = false;
httpd.registerPathHandler(
'/remote.png',
{
handle: function (request, response) {
Zotero.debug('Something loaded the image')
response.setHeader('Content-Type', 'image/png', false);
response.setStatusLine(null, 200, 'OK');
response.write('');
pngRequested = true;
}
}
);
});
after(async function () {
await new Promise(resolve => httpd.stop(resolve));
@ -22,6 +40,22 @@ describe("HiddenBrowser", function() {
let e = await getPromiseError(HiddenBrowser.create(baseURL + 'nonexistent', { requireSuccessfulStatus: true }));
assert.instanceOf(e, Zotero.HTTP.UnexpectedStatusException);
});
it("should prevent a remote request with blockRemoteResources", async function () {
let path = OS.Path.join(getTestDataDirectory().path, 'test-hidden.html');
let browser = await HiddenBrowser.create(path, { blockRemoteResources: true });
await HiddenBrowser.getPageData(browser, ['characterSet', 'bodyText']);
HiddenBrowser.destroy(browser);
assert.isFalse(pngRequested);
});
it("should allow a remote request without blockRemoteResources", async function () {
let path = OS.Path.join(getTestDataDirectory().path, 'test-hidden.html');
let browser = await HiddenBrowser.create(path, { blockRemoteResources: false });
await HiddenBrowser.getPageData(browser, ['characterSet', 'bodyText']);
HiddenBrowser.destroy(browser);
assert.isTrue(pngRequested);
});
});
describe("#getPageData()", function () {