mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Don't update item when leaving an empty field

Browse source 
It looks like this has been happening for at least all of 3.0, including
when tabbing between empty fields.
This commit is contained in:
Dan Stillman 2013-02-04 03:40:57 -05:00
parent 1b1df60725
commit 194343cb0f
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
chrome/content/zotero/xpcom/data/item.js
View file

@ -770,7 +770,11 @@ Zotero.Item.prototype.setField = function(field, value, loadIn) {
return true;
}
if (!Zotero.ItemFields.isValidForType(fieldID, this.itemTypeID)) {
if (value === "") {
value = false;
}
if (value !== false && !Zotero.ItemFields.isValidForType(fieldID, this.itemTypeID)) {
var msg = "'" + field + "' is not a valid field for type " + this.itemTypeID;
if (loadIn) {
@ -806,7 +810,9 @@ Zotero.Item.prototype.setField = function(field, value, loadIn) {
}
// If existing value, make sure it's actually changing
if ((this._itemData[fieldID] + "") === (value + "")) {
if ((typeof this._itemData[fieldID] == 'undefined' && value === false)
|| (typeof this._itemData[fieldID] != 'undefined'
&& this._itemData[fieldID] === value)) {
return false;
}