mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Don't repeatedly upload relations

Browse source 
Fixes #2772
This commit is contained in:
Dan Stillman 2022-08-22 01:11:11 -04:00
parent 454368e3d3
commit 170f1962ad
2 changed files with 37 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

36
test/tests/dataObjectUtilitiesTest.js
View file

@ -59,6 +59,42 @@ describe("Zotero.DataObjectUtilities", function() {
// place was already empty, so it shouldn't be included
assert.notProperty(obj, 'place');
});
it("shouldn't include relations that haven't changed", function () {
var patchBase = {
title: "Old Title",
relations: {
"mendeleyDB:documentUUID": "6b97abe6-8e23-4471-b963-234cf26808b9"
}
};
var obj = {
title: "New Title",
relations: {
"mendeleyDB:documentUUID": "6b97abe6-8e23-4471-b963-234cf26808b9"
}
}
obj = Zotero.DataObjectUtilities.patch(patchBase, obj);
assert.notProperty(obj, 'relations');
});
it("shouldn't include relations that only switched from string to array", function () {
var patchBase = {
title: "Old Title",
relations: {
"mendeleyDB:documentUUID": "6b97abe6-8e23-4471-b963-234cf26808b9"
}
};
var obj = {
title: "New Title",
relations: {
"mendeleyDB:documentUUID": [
"6b97abe6-8e23-4471-b963-234cf26808b9"
]
}
}
obj = Zotero.DataObjectUtilities.patch(patchBase, obj);
assert.notProperty(obj, 'relations');
});
})
describe("#diff()", function () {