mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix innocuous "itemProgress is not defined" error

Browse source
This commit is contained in:
Simon Kornblith 2013-08-15 13:59:43 -04:00
parent dde09c54a2
commit 14192059ce
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
chrome/content/zotero/browser.js
View file

@ -58,6 +58,7 @@ var Zotero_Browser = new function() {
this.isScraping = false; this.isScraping = false;
var _browserData = new Object(); var _browserData = new Object();
var _attachmentsMap = new WeakMap();
var _blacklist = [ var _blacklist = [
"googlesyndication.com", "googlesyndication.com",
@ -533,6 +534,7 @@ var Zotero_Browser = new function() {
translate.clearHandlers("done"); translate.clearHandlers("done");
translate.clearHandlers("itemDone"); translate.clearHandlers("itemDone");
translate.clearHandlers("attachmentProgress");
translate.setHandler("done", function(obj, returnValue) { translate.setHandler("done", function(obj, returnValue) {
if(!returnValue) { if(!returnValue) {
@ -550,8 +552,6 @@ var Zotero_Browser = new function() {
Zotero_Browser.isScraping = false; Zotero_Browser.isScraping = false;
}); });
var attachmentsMap = new WeakMap();
translate.setHandler("itemDone", function(obj, dbItem, item) { translate.setHandler("itemDone", function(obj, dbItem, item) {
Zotero_Browser.progress.show(); Zotero_Browser.progress.show();
var itemProgress = new Zotero_Browser.progress.ItemProgress(Zotero.ItemTypes.getImageSrc(item.itemType), var itemProgress = new Zotero_Browser.progress.ItemProgress(Zotero.ItemTypes.getImageSrc(item.itemType),
@ -559,7 +559,7 @@ var Zotero_Browser = new function() {
itemProgress.setProgress(100); itemProgress.setProgress(100);
for(var i=0; i<item.attachments.length; i++) { for(var i=0; i<item.attachments.length; i++) {
var attachment = item.attachments[i]; var attachment = item.attachments[i];
attachmentsMap.set(attachment, _attachmentsMap.set(attachment,
new Zotero_Browser.progress.ItemProgress( new Zotero_Browser.progress.ItemProgress(
Zotero.Utilities.determineAttachmentIcon(attachment), Zotero.Utilities.determineAttachmentIcon(attachment),
attachment.title, itemProgress)); attachment.title, itemProgress));
@ -572,7 +572,7 @@ var Zotero_Browser = new function() {
}); });
translate.setHandler("attachmentProgress", function(obj, attachment, progress, error) { translate.setHandler("attachmentProgress", function(obj, attachment, progress, error) {
var itemProgress = attachmentsMap.get(attachment); var itemProgress = _attachmentsMap.get(attachment);
if(progress === false) { if(progress === false) {
itemProgress.setError(); itemProgress.setError();
} else { } else {