mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Changes date parsing and handling for feeds. Closes #1024, #1025

Browse source
This commit is contained in:
Adomas Venčkauskas 2016-06-13 13:03:20 +03:00
parent a200f6cfc5
commit 137290b97f
6 changed files with 110 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

42
test/tests/feedItemTest.js
View file

@ -92,18 +92,36 @@ describe("Zotero.FeedItem", function () {
});
describe("#fromJSON()", function() {
it("should attempt to parse non ISO-8601 dates", function* () {
var json = {
itemType: "journalArticle",
accessDate: "2015-06-07 20:56:00",
dateAdded: "18-20 June 2015", // magically parsed by `new Date()`
dateModified: "07/06/2015", // US
};
var item = new Zotero.FeedItem;
item.fromJSON(json);
assert.strictEqual(item.getField('accessDate'), '2015-06-07 20:56:00');
assert.strictEqual(item.getField('dateAdded'), '2015-06-18 20:00:00');
// sets a timezone specific hour when new Date parses from strings without hour specified.
assert.strictEqual(item.getField('dateModified'), Zotero.Date.dateToSQL(new Date(2015, 6, 6), true));
Zotero.locale = 'en-US';
var data = [
{
itemType: "journalArticle",
date: "2015-06-07 20:56:00" // sql
},
{
itemType: "journalArticle",
date: "Mon, 13 Jun 2016 06:25:57 EDT" // HTTP
},
{
itemType: "journalArticle",
date: "18-20 June 2015" // parsed by `strToDate`
},
{
itemType: "journalArticle",
date: "06/07/2015" // american format also parsed by `strToDate`
}
];
var expectedDates = [
'2015-06-07 20:56:00',
'2016-06-13 10:25:57',
'2015-06-18',
'2015-06-07'
];
for (let i = 0; i < data.length; i++) {
var item = new Zotero.FeedItem;
item.fromJSON(data[i]);
assert.strictEqual(item.getField('date'), expectedDates[i]);
}
})
});
describe("#save()", function() {