mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Swap "Split Vertically" and "Split Horizontally" in PDF reader

Browse source
This commit is contained in:
Dan Stillman 2022-09-30 04:22:48 -04:00
parent 8fc9ebe4ab
commit 12b1897478
3 changed files with 20 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
chrome/content/zotero/reader.xul
View file

@ -164,18 +164,18 @@
oncommand="menuCmd('zoomPageHeight')" oncommand="menuCmd('zoomPageHeight')"
/> />
<menuseparator class="menu-type-reader"/> <menuseparator class="menu-type-reader"/>
<menuitem
id="view-menuitem-split-horizontally"
type="checkbox"
label="aaa &zotero.pdfReader.splitHorizontally;"
oncommand="menuCmd('splitHorizontally')"
/>
<menuitem <menuitem
id="view-menuitem-split-vertically" id="view-menuitem-split-vertically"
type="checkbox" type="checkbox"
label="&zotero.pdfReader.splitVertically;" label="&zotero.pdfReader.splitVertically;"
oncommand="menuCmd('splitVertically')" oncommand="menuCmd('splitVertically')"
/> />
<menuitem
id="view-menuitem-split-horizontally"
type="checkbox"
label="&zotero.pdfReader.splitHorizontally;"
oncommand="menuCmd('splitHorizontally')"
/>
</menupopup> </menupopup>
</menu> </menu>
<menu <menu

14
chrome/content/zotero/standalone/standalone.xul
View file

@ -337,13 +337,6 @@
oncommand="ZoteroStandalone.onReaderCmd('zoomPageHeight')" oncommand="ZoteroStandalone.onReaderCmd('zoomPageHeight')"
/> />
<menuseparator class="menu-type-reader"/> <menuseparator class="menu-type-reader"/>
<menuitem
id="view-menuitem-split-vertically"
class="menu-type-reader"
type="checkbox"
label="&zotero.pdfReader.splitVertically;"
oncommand="ZoteroStandalone.onReaderCmd('splitVertically')"
/>
<menuitem <menuitem
id="view-menuitem-split-horizontally" id="view-menuitem-split-horizontally"
class="menu-type-reader" class="menu-type-reader"
@ -351,6 +344,13 @@
label="&zotero.pdfReader.splitHorizontally;" label="&zotero.pdfReader.splitHorizontally;"
oncommand="ZoteroStandalone.onReaderCmd('splitHorizontally')" oncommand="ZoteroStandalone.onReaderCmd('splitHorizontally')"
/> />
<menuitem
id="view-menuitem-split-vertically"
class="menu-type-reader"
type="checkbox"
label="&zotero.pdfReader.splitVertically;"
oncommand="ZoteroStandalone.onReaderCmd('splitVertically')"
/>
<menuseparator class="menu-type-reader"/> <menuseparator class="menu-type-reader"/>
<menu id="layout-menu" label="&layout.label;"> <menu id="layout-menu" label="&layout.label;">

14
chrome/content/zotero/xpcom/reader.js
View file

@ -698,13 +698,6 @@ class ReaderInstance {
popup.appendChild(menuitem); popup.appendChild(menuitem);
// Separator // Separator
popup.appendChild(this._window.document.createElement('menuseparator')); popup.appendChild(this._window.document.createElement('menuseparator'));
// Split Vertically
menuitem = this._window.document.createElement('menuitem');
menuitem.setAttribute('label', Zotero.getString('pdfReader.splitVertically'));
menuitem.setAttribute('type', 'checkbox');
menuitem.setAttribute('checked', this.isSplitVerticallyActive());
menuitem.addEventListener('command', () => this._splitVertically());
popup.appendChild(menuitem);
// Split Horizontally // Split Horizontally
menuitem = this._window.document.createElement('menuitem'); menuitem = this._window.document.createElement('menuitem');
menuitem.setAttribute('label', Zotero.getString('pdfReader.splitHorizontally')); menuitem.setAttribute('label', Zotero.getString('pdfReader.splitHorizontally'));
@ -712,6 +705,13 @@ class ReaderInstance {
menuitem.setAttribute('checked', this.isSplitHorizontallyActive()); menuitem.setAttribute('checked', this.isSplitHorizontallyActive());
menuitem.addEventListener('command', () => this._splitHorizontally()); menuitem.addEventListener('command', () => this._splitHorizontally());
popup.appendChild(menuitem); popup.appendChild(menuitem);
// Split Vertically
menuitem = this._window.document.createElement('menuitem');
menuitem.setAttribute('label', Zotero.getString('pdfReader.splitVertically'));
menuitem.setAttribute('type', 'checkbox');
menuitem.setAttribute('checked', this.isSplitVerticallyActive());
menuitem.addEventListener('command', () => this._splitVertically());
popup.appendChild(menuitem);
// Separator // Separator
popup.appendChild(this._window.document.createElement('menuseparator')); popup.appendChild(this._window.document.createElement('menuseparator'));
// Next page // Next page