mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Clear changed state of annotation after saving color change

Browse source 
This was resulting in an extra 'modify' event after each sync upload.
This commit is contained in:
Dan Stillman 2021-04-24 19:48:27 -04:00
parent ea42789206
commit 0d377a1c4a
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
chrome/content/zotero/xpcom/data/item.js
View file

@ -1873,7 +1873,7 @@ Zotero.Item.prototype._saveData = Zotero.Promise.coroutine(function* (env) {
}.bind(this)); }.bind(this));
} }
let fields = ['Type', 'Text', 'Comment', 'PageLabel', 'SortIndex', 'Position', 'IsExternal']; let fields = ['Type', 'Text', 'Comment', 'Color', 'PageLabel', 'SortIndex', 'Position', 'IsExternal'];
for (let field of fields) { for (let field of fields) {
this._clearChanged('annotation' + field); this._clearChanged('annotation' + field);
} }

1
test/tests/itemTest.js
View file

@ -1339,6 +1339,7 @@ describe("Zotero.Item", function () {
annotation.parentID = attachment.id; annotation.parentID = attachment.id;
annotation.annotationType = 'highlight'; annotation.annotationType = 'highlight';
annotation.annotationText = "This is highlighted text."; annotation.annotationText = "This is highlighted text.";
annotation.annotationColor = "#ffff66";
annotation.annotationSortIndex = '00015|002431|00000'; annotation.annotationSortIndex = '00015|002431|00000';
annotation.annotationPosition = JSON.stringify({ annotation.annotationPosition = JSON.stringify({
pageIndex: 123, pageIndex: 123,