mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Improve cookie-sandbox behavior when getting attachments via WBP

Browse source 
Previously cookies only got attached on the initial request but not on
any redirect and subsequent request. This may have been the cause for
many reports of import failures behind proxies in the past.
This commit is contained in:
Adomas Venčkauskas 2022-11-11 12:46:23 +02:00
parent 02098a9a34
commit 0aae101196
1 changed files with 11 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
chrome/content/zotero/xpcom/cookieSandbox.js
View file

@ -317,10 +317,17 @@ Zotero.CookieSandbox.Observer = new function() {
this.trackedInterfaceRequestors.splice(i, 1);
this.trackedInterfaceRequestorSandboxes.splice(i, 1);
i--;
} else if(ir == notificationCallbacks) {
// We are tracking this interface requestor
trackedBy = this.trackedInterfaceRequestorSandboxes[i];
break;
} else {
let tracked = ir === notificationCallbacks;
try {
tracked = ir === notificationCallbacks.getInterface(Ci.nsIWebBrowserPersist);
} catch (e) { }
if (tracked) {
// We are tracking this interface requestor
trackedBy = this.trackedInterfaceRequestorSandboxes[i];
break;
}
}
}
@ -350,12 +357,6 @@ Zotero.CookieSandbox.Observer = new function() {
notificationCallbacks.QueryInterface(Components.interfaces.nsIXMLHttpRequest);
tested = true;
} catch(e) {}
if(!tested) {
try {
notificationCallbacks.QueryInterface(Components.interfaces.nsIWebBrowserPersist);
tested = true;
} catch(e) {}
}
}
}
}