mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't set collections: "" in PATCH JSON when changing item to child

Browse source
This commit is contained in:
Dan Stillman 2015-10-29 03:03:25 -04:00
parent 5c32962bb1
commit 0803bb84e3
2 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
chrome/content/zotero/xpcom/data/dataObjectUtilities.js
View file

@ -132,6 +132,11 @@ Zotero.DataObjectUtilities = {
// If field from base doesn't exist in new version, clear it
else {
switch (i) {
// When changing an item from top-level to child, the collections property is
// no valid, so it doesn't need to be cleared
case 'collections':
break;
case 'deleted':
target[i] = false;
break;

11
test/tests/dataObjectUtilitiesTest.js
View file

@ -1,6 +1,17 @@
"use strict";
describe("Zotero.DataObjectUtilities", function() {
describe("#patch()", function () {
it("should omit 'collections' if it doesn't exist", function* () {
var patchBase = {
collections: ['AAAAAAAA']
};
var obj = {};
obj = Zotero.DataObjectUtilities.patch(patchBase, obj);
assert.notProperty(obj, 'collections');
})
})
describe("#diff()", function () {
// This is mostly covered by syncLocal::_reconcileChanges() tests, but we test some
// additional things here