mirrors/zotero
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Try to make numDistinctFileAttachmentsForLabel() test more reliable

Browse source
This commit is contained in:
Dan Stillman 2024-05-15 06:09:40 -04:00
parent 0c8d3f0829
commit 07e8f0a01d
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/tests/itemsTest.js
View file

@ -1326,7 +1326,7 @@ describe("Zotero.Items", function () {
describe("#numDistinctFileAttachmentsForLabel()", function () { describe("#numDistinctFileAttachmentsForLabel()", function () {
it("should count parent item and best attachment as one item when best-attachment state is cached", async function () { it("should return an approximate count of attachment files for the selected items", async function () {
var item1 = await createDataObject('item'); var item1 = await createDataObject('item');
var attachment1 = await importFileAttachment('test.png', { parentItemID: item1.id }); var attachment1 = await importFileAttachment('test.png', { parentItemID: item1.id });
var attachment2 = await importFileAttachment('test.png', { parentItemID: item1.id }); var attachment2 = await importFileAttachment('test.png', { parentItemID: item1.id });
@ -1342,6 +1342,8 @@ describe("Zotero.Items", function () {
await zp.selectItems([item1.id]); await zp.selectItems([item1.id]);
assert.equal(getNum(), 1); assert.equal(getNum(), 1);
await zp.selectItems([item1.id, attachment1.id]); await zp.selectItems([item1.id, attachment1.id]);
// Make sure the best-attachment state is uncached
item1._bestAttachmentState = null;
// Should count parent item and best attachment as two item when uncached // Should count parent item and best attachment as two item when uncached
assert.equal(getNum(), 2); assert.equal(getNum(), 2);
await zp.selectItems([item1.id, attachment1.id, attachment2.id]); await zp.selectItems([item1.id, attachment1.id, attachment2.id]);