From 060d2f1c37d50eec9214875b75b9af4fa957e66b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adomas=20Ven=C4=8Dkauskas?= <adomas.ven@gmail.com>
Date: Wed, 2 Feb 2022 12:25:31 +0200
Subject: [PATCH] Item tree: Add tooltips for header cells.

Restrict the html-tooltip [title] selector to not fall back to
window title when no title attributes are present.
---
 chrome/content/zotero/components/virtualized-table.jsx | 3 ++-
 chrome/content/zotero/zoteroPane.xul                   | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/chrome/content/zotero/components/virtualized-table.jsx b/chrome/content/zotero/components/virtualized-table.jsx
index a149afc67f..ae1e6b24b7 100644
--- a/chrome/content/zotero/components/virtualized-table.jsx
+++ b/chrome/content/zotero/components/virtualized-table.jsx
@@ -1051,7 +1051,8 @@ class VirtualizedTable extends React.Component {
 					{resizer}
 					<span
 						key={columnName + '-label'}
-						className={`label ${column.dataKey}`}>
+						className={`label ${column.dataKey}`}
+						title={columnName}>
 						{label}
 					</span>
 					{sortIndicator}
diff --git a/chrome/content/zotero/zoteroPane.xul b/chrome/content/zotero/zoteroPane.xul
index 5cc0ad9e60..53adedefe2 100644
--- a/chrome/content/zotero/zoteroPane.xul
+++ b/chrome/content/zotero/zoteroPane.xul
@@ -246,7 +246,7 @@
 					
 					<popupset>
 						<!-- Allows to display a tooltip for 'title' attrbute for HTML nodes. Must be on an XUL node i.e. iframe or toolbar: "tooltip"="html-tooltip" -->
-						<tooltip id="html-tooltip" onpopupshowing="if (document.tooltipNode &amp;&amp; (tooltipTitleNode = document.tooltipNode.closest('*[title]'))) {this.setAttribute('label', tooltipTitleNode.getAttribute('title')); return true; } return false"/>
+						<tooltip id="html-tooltip" onpopupshowing="if (document.tooltipNode &amp;&amp; (tooltipTitleNode = document.tooltipNode.closest('div *[title], iframe *[title], browser *[title]'))) {this.setAttribute('label', tooltipTitleNode.getAttribute('title')); return true; } return false"/>
 						<menupopup id="zotero-collectionmenu"
 								oncommand="ZoteroPane.onCollectionContextMenuSelect(event)">
 							<!-- Keep order in sync with buildCollectionContextMenu, which adds additional attributes -->
@@ -358,7 +358,7 @@
 						</splitter>
 						
 						<box id="zotero-layout-switcher" orient="horizontal" zotero-persist="orient" flex="1">
-							<hbox id="zotero-items-pane" class="virtualized-table-container" zotero-persist="width height" flex="1" clickthrough="never">
+							<hbox id="zotero-items-pane" class="virtualized-table-container" zotero-persist="width height" flex="1" clickthrough="never" tooltip="html-tooltip">
 								<html:div id="zotero-items-tree"></html:div>
 							</hbox>